Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Asp.Versioning.Mvc to replace Microsoft.AspNetCore.Mvc.Versioning. #18380

Merged
merged 2 commits into from Dec 30, 2023

Conversation

maliming
Copy link
Member

@maliming maliming commented Dec 6, 2023

Resolve #18368

Breaking change: the namespace of [ControllerName] attribute has changed to using Asp.Versioning;

@maliming maliming added this to the 8.1-preview milestone Dec 6, 2023
@maliming maliming marked this pull request as ready for review December 18, 2023 07:17
Copy link

codecov bot commented Dec 18, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (006b26e) 51.72% compared to head (090df53) 51.72%.
Report is 220 commits behind head on dev.

Files Patch % Lines
.../DependencyInjection/AbpApiVersioningExtensions.cs 20.00% 1 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #18380      +/-   ##
==========================================
- Coverage   51.72%   51.72%   -0.01%     
==========================================
  Files        3075     3075              
  Lines       96949    96951       +2     
  Branches     7719     7721       +2     
==========================================
  Hits        50146    50146              
  Misses      45268    45268              
- Partials     1535     1537       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hikalkan hikalkan merged commit eb75051 into dev Dec 30, 2023
3 of 5 checks passed
@hikalkan hikalkan deleted the Asp.Versioning.Mvc branch December 30, 2023 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace Microsoft.AspNetCore.Mvc.Versioning with Asp.Versioning.Mvc
2 participants