Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove striped-rows from tables #18941

Merged
merged 1 commit into from
Feb 6, 2024
Merged

Remove striped-rows from tables #18941

merged 1 commit into from
Feb 6, 2024

Conversation

enisn
Copy link
Member

@enisn enisn commented Feb 5, 2024

Description

Closes #18906

Checklist

  • I fully tested it as developer / designer and created unit / integration tests
  • I documented it (or no need to document or I will create a separate documentation issue)

How to test it?

Please describe how this can be tested by the test engineers if it is not already explicit - or remove this section if no need to description.

@enisn enisn added this to the 8.0-patch milestone Feb 5, 2024
Copy link

codecov bot commented Feb 5, 2024

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (da59ccb) 51.60% compared to head (a19a13f) 51.61%.
Report is 22 commits behind head on rel-8.0.

Files Patch % Lines
...etCore/VirtualFileSystem/WebContentFileProvider.cs 0.00% 3 Missing and 1 partial ⚠️
...c.UI.Bootstrap.Demo/Pages/Components/Tables.cshtml 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           rel-8.0   #18941   +/-   ##
========================================
  Coverage    51.60%   51.61%           
========================================
  Files         3077     3077           
  Lines        97270    97271    +1     
  Branches      7746     7747    +1     
========================================
+ Hits         50200    50206    +6     
+ Misses       45524    45518    -6     
- Partials      1546     1547    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oykuermann
Copy link
Contributor

  • Mvc - On light theme (every table), the stripped-table view was not removed:
    image
    image

  • Blazor Server & Blazor Web Assembly - On light theme, Security Logs stripped-table view was not removed:
    image

Copy link
Contributor

@oykuermann oykuermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll check after changes

@oykuermann oykuermann merged commit c1a26b5 into rel-8.0 Feb 6, 2024
4 of 5 checks passed
@oykuermann oykuermann deleted the 8.0-no-table-striped branch February 6, 2024 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants