Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs improvements #19277

Merged
merged 3 commits into from
Mar 14, 2024
Merged

docs improvements #19277

merged 3 commits into from
Mar 14, 2024

Conversation

salihozkara
Copy link
Member

@salihozkara salihozkara commented Mar 12, 2024

Description

get from cache inside the loop was a costly approach, so instead we get from cache before the loop and used inside the loop.

Checklist

  • I fully tested it as developer / designer and created unit / integration tests

@salihozkara salihozkara marked this pull request as draft March 12, 2024 21:20
@salihozkara salihozkara added this to the 8.2-preview milestone Mar 13, 2024
@salihozkara salihozkara marked this pull request as ready for review March 13, 2024 11:53
Copy link

codecov bot commented Mar 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.52%. Comparing base (f2405ab) to head (13928e1).
Report is 32 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #19277      +/-   ##
==========================================
- Coverage   51.53%   51.52%   -0.01%     
==========================================
  Files        3097     3097              
  Lines       98504    98504              
  Branches     7873     7873              
==========================================
- Hits        50761    50754       -7     
- Misses      46179    46185       +6     
- Partials     1564     1565       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EngincanV EngincanV requested review from maliming and removed request for EngincanV March 13, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants