New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move pagination functionality from `extensible-table.component.ts` to `ngx-datatable-list.directive.ts` #19401

Merged

oykuermann merged 7 commits into rel-8.1 from issue-19400

Mar 26, 2024

Member

Sinan997 commented Mar 22, 2024

Resolves #19400


          Move pagination functinality from extensible-table to ngx-datatable-l…

4c4124d

…ist.directive

Sinan997 added bug ui-angular labels

Sinan997 added this to the 8.1-final milestone

Sinan997 requested review from masumulu28 and oykuermann

March 22, 2024 14:17

Sinan997 commented

View reviewed changes

npm/ng-packs/packages/theme-shared/src/lib/directives/ngx-datatable-list.directive.ts Show resolved Hide resolved

masumulu28 reviewed

View reviewed changes

npm/ng-packs/packages/theme-shared/src/lib/directives/ngx-datatable-list.directive.ts Outdated Show resolved Hide resolved


          remove subscription and use angular new features

3156c1a

Sinan997 requested a review from masumulu28

March 22, 2024 14:45

Sinan997 changed the title ~~Move pagination functinality from extensible-table.component.ts to ngx-datatable-list.directive.ts~~ Move pagination functionality from extensible-table.component.ts to ngx-datatable-list.directive.ts

masumulu28 reviewed

View reviewed changes

npm/ng-packs/packages/theme-shared/src/lib/directives/ngx-datatable-list.directive.ts Outdated Show resolved Hide resolved

masumulu28 reviewed

View reviewed changes

npm/ng-packs/packages/theme-shared/src/lib/directives/ngx-datatable-list.directive.ts Outdated Show resolved Hide resolved

masumulu28 reviewed

View reviewed changes

npm/ng-packs/packages/theme-shared/src/lib/directives/ngx-datatable-list.directive.ts Outdated Show resolved Hide resolved

masumulu28 reviewed

View reviewed changes

npm/ng-packs/packages/theme-shared/src/lib/directives/ngx-datatable-list.directive.ts Outdated Show resolved Hide resolved


          mark protected helper methods instead of private

c9cb11d

Sinan997 requested a review from masumulu28

March 25, 2024 15:26

masumulu28 added 2 commits

March 25, 2024 21:09


          Update imports order

dd2769a


          Update ngx-datatable-list.directive.ts

48e5f56

masumulu28 approved these changes

View reviewed changes

Member

masumulu28 commented Mar 25, 2024

@oykuermann all cases filtering | pagination | order may effect this changes, can you please test with more than 20 data (like language-management)

oykuermann requested changes

View reviewed changes

Contributor

oykuermann left a comment

Pagination does not work after entity generation:

26.03.2024.08_44.webm

Member

masumulu28 commented Mar 26, 2024

@Sinan997 can you help to Öykü for testing

Sinan997 added 2 commits

March 26, 2024 15:46


          use table count instead of list count

2e60403


          use table count instead of list count

fffe4fc

oykuermann approved these changes

View reviewed changes

oykuermann merged commit 5ca13df into rel-8.1

2 of 3 checks passed

oykuermann deleted the issue-19400 branch

March 26, 2024 14:06

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment