Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSSStyleDeclaration #42

Closed
1 task done
abrahamjuliot opened this issue Jul 25, 2020 · 7 comments
Closed
1 task done

CSSStyleDeclaration #42

abrahamjuliot opened this issue Jul 25, 2020 · 7 comments
Labels
enhancement New feature or request

Comments

@abrahamjuliot
Copy link
Owner

abrahamjuliot commented Jul 25, 2020 •
edited
Loading

https://developer.mozilla.org/en-US/docs/Web/API/Window/getComputedStyle

  • test for breakage by injecting style to the body via inline styles, stylesheet, and style tag
    -- results not affected/no breakage:
    [1] removed the stylesheet
    [2] appended stylesheet (bootstrap cdn)
    [3] added style tag with color: blue !important
    [4] added inline style with color: blue !important
@abrahamjuliot abrahamjuliot added the bug Something isn't working label Jul 25, 2020
abrahamjuliot added a commit that referenced this issue Jul 29, 2020
@abrahamjuliot
computed style support in Firefox #42
0a0bf13
abrahamjuliot added a commit that referenced this issue Aug 1, 2020
@abrahamjuliot
computed styles: use for...in (chrome support) #42
9b3ffbc
abrahamjuliot added a commit that referenced this issue Aug 2, 2020
@abrahamjuliot
bug fix #42
138c423
abrahamjuliot added a commit that referenced this issue Aug 2, 2020
@abrahamjuliot
uniqueKeys fix #42
e6f699b
@abrahamjuliot abrahamjuliot changed the title computed style support in Firefox computed style support Aug 2, 2020
@abrahamjuliot abrahamjuliot added the enhancement New feature or request label Aug 2, 2020
@abrahamjuliot abrahamjuliot changed the title computed style support cross browser computed style support Aug 2, 2020
abrahamjuliot added a commit that referenced this issue Aug 2, 2020
@abrahamjuliot
capture missing aliases #42
8cd55cb
abrahamjuliot added a commit that referenced this issue Aug 2, 2020
@abrahamjuliot
refactor hasAlias #42
4ce0cbc
abrahamjuliot added a commit that referenced this issue Aug 2, 2020
@abrahamjuliot
tidy hasAlias #42
76d9fd9
abrahamjuliot added a commit that referenced this issue Aug 2, 2020
@abrahamjuliot
increase stats collected #42
f2bf812
abrahamjuliot added a commit that referenced this issue Aug 2, 2020
@abrahamjuliot
tidy template #42
5cfeb1a
abrahamjuliot added a commit that referenced this issue Aug 2, 2020
@abrahamjuliot
capture HTMLElement.style #42
f4ce27a
abrahamjuliot added a commit that referenced this issue Aug 2, 2020
@abrahamjuliot
tidy hasCounterpart() #42
41f5ae7
abrahamjuliot added a commit that referenced this issue Aug 3, 2020
@abrahamjuliot
add CSSStyleDeclaration checks #42
450ffda
abrahamjuliot added a commit that referenced this issue Aug 3, 2020
@abrahamjuliot
tify styleVersion #42
e1929f5
abrahamjuliot added a commit that referenced this issue Aug 3, 2020
@abrahamjuliot
own property bug fix #42
81f41f6
abrahamjuliot added a commit that referenced this issue Aug 3, 2020
@abrahamjuliot
tidy styleVersion #42
f2ac102
abrahamjuliot added a commit that referenced this issue Aug 3, 2020
@abrahamjuliot
iframe styleVersion & adjust moz/wekit #42
371e82d
abrahamjuliot added a commit that referenced this issue Aug 3, 2020
@abrahamjuliot
revert to devElement #42
998f5fb
@abrahamjuliot abrahamjuliot reopened this Aug 3, 2020
@abrahamjuliot abrahamjuliot changed the title cross browser computed style support CSSStyleDeclaration Aug 3, 2020
@abrahamjuliot abrahamjuliot removed the bug Something isn't working label Aug 3, 2020
@abrahamjuliot abrahamjuliot pinned this issue Aug 3, 2020
abrahamjuliot added a commit that referenced this issue Aug 3, 2020
@abrahamjuliot
get body, drop ownPropertyKeys, return unique keys #42
8826cb0
abrahamjuliot added a commit that referenced this issue Aug 3, 2020
@abrahamjuliot
improve hasCounterpart readability #42
5372cc9
abrahamjuliot added a commit that referenced this issue Aug 4, 2020
@abrahamjuliot
capture keys in HTMLElement #54 fix/improve css style template #42
268aed9
@abrahamjuliot
Copy link
Owner Author

abrahamjuliot commented Aug 4, 2020 •
edited
Loading

disregarding https://developer.mozilla.org/en-US/docs/Web/API/Element/computedStyleMap
https://developers.google.com/web/updates/2018/03/cssom

@abrahamjuliot abrahamjuliot mentioned this issue Aug 4, 2020
Closed
abrahamjuliot added a commit that referenced this issue Aug 4, 2020
@abrahamjuliot
improve hasCounterpart perf #42
a459094
@abrahamjuliot
Copy link
Owner Author

abrahamjuliot commented Aug 4, 2020 •
edited
Loading

Interesting find in Chrome:

  • HTMLElement.style and CSSRuleList.style only reveal alias attributes via the for...in loop. But, named attributes are valid on the CSSStyleDeclaration object:. For example, zIndex is returned via the for...in loop and not z-index, but 'z-index' in obj is true and obj['z-index'] returns a valid result "" instead of undefined. "The in operator returns true if the specified property is in the specified object or its prototype chain." - MDN

@abrahamjuliot
Copy link
Owner Author 

//returns the prototype
Object.getOwnPropertyNames(Object.getPrototypeOf(document.body.style))

abrahamjuliot added a commit that referenced this issue Aug 4, 2020
@abrahamjuliot
refactor and use new Set() for unique lists #42
41de9b9
abrahamjuliot referenced this issue Aug 4, 2020
@abrahamjuliot
refactor hasCounterpart to get all attributes, refactor methods/prope…
d2c1ffc 
…rties and drop collection of keys and drop methods and properties from results
@abrahamjuliot
Copy link
Owner Author

abrahamjuliot commented Aug 4, 2020 •
edited
Loading

d2c1ffc fixes Chrome and gives balanced/accurate readings across all 3 tests

  • dropped total keys since it is unnecessary and subject to easy manipulation
  • dropped methods and properties from the result to reduce output. Note, FF counts alias and named attributes as properties, so including it in the output is a useful option.

abrahamjuliot added a commit that referenced this issue Aug 4, 2020
@abrahamjuliot
return sort() to identify equal hashes #42
6723ecb
abrahamjuliot added a commit that referenced this issue Aug 5, 2020
@abrahamjuliot
rewrite styleVersion from ground up #42
dbea648
@abrahamjuliot
Copy link
Owner Author

abrahamjuliot commented Aug 5, 2020 •
edited
Loading

dbea648:

  • preserve order -- entropy evidenced in chrome see 1107088
  • sort in a separate check to determine if keys are matching
  • identify prototype name -- FF and Chrome differ
  • drop CSSRuleList.style argument type check -- not required since I collect all properties and ignore duplicates
  • reduce styleVersion code
  • improve caniuse helper method to limit errors

abrahamjuliot referenced this issue Aug 5, 2020
@abrahamjuliot
handle Tor Browser webgl denial errors #27
63799d5
abrahamjuliot added a commit that referenced this issue Aug 5, 2020
@abrahamjuliot
sort keys: injected styles throws off order #42
1107088
@abrahamjuliot
Copy link
Owner Author

Safari Version 13.0.5 (15608.5.11): getComputedStyles returns an additional 9 keys
https://www.diffchecker.com/eJOL5Dhf

abrahamjuliot added a commit that referenced this issue Aug 29, 2020
@abrahamjuliot
support Safari #28 #36 #42 #53 #56 #63
d106814
@abrahamjuliot
Copy link
Owner Author

System Styles #70

abrahamjuliot added a commit that referenced this issue Sep 6, 2020
@abrahamjuliot
system styles #70 #42
092b5d1
@abrahamjuliot abrahamjuliot unpinned this issue Sep 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@abrahamjuliot