context: add basic support for context #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This doesn't add full support. Doing so requires cooperation from the libraries. However, this does solve the case where a request is cancelled, we don't block and return control to the caller. The consequence is that we're leaking a goroutine for the remainder of the open request to memcache/redis (which shouldn't be long) Both libraries expose the ability to set timeouts on connections. It might be worthwhile to see how to integrate them more seamlessly: https://godoc.org/github.com/bradfitz/gomemcache/memcache#ConnectTimeoutError https://godoc.org/github.com/gomodule/redigo/redis#DoWithTimeout
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn't add full support. Doing so requires cooperation from the
libraries. However, this does solve the case where a request is
cancelled, we don't block and return control to the caller. The
consequence is that we're leaking a goroutine for the remainder of the
open request to memcache/redis (which shouldn't be long)
Both libraries expose the ability to set timeouts on connections. It
might be worthwhile to see how to integrate them more seamlessly:
https://godoc.org/github.com/bradfitz/gomemcache/memcache#ConnectTimeoutError
https://godoc.org/github.com/gomodule/redigo/redis#DoWithTimeout