Release files for 2.5.0-rc2

* Release files for 2.5.0-rc2
* Code changes from 2.5.0-rc1 --> 2.5.0-rc2 (#2686)
* Update docs regarding Ubuntu 24.04

configure

@@ -1,6 +1,6 @@
 #! /bin/sh
 # Guess values for system-dependent variables and create Makefiles.
-# Generated by GNU Autoconf 2.69 for onedrive v2.5.0-rc1.
+# Generated by GNU Autoconf 2.69 for onedrive v2.5.0-rc2.
 #
 # Report bugs to <https://github.com/abraunegg/onedrive>.
 #
@@ -579,8 +579,8 @@ MAKEFLAGS=
 # Identity of this package.
 PACKAGE_NAME='onedrive'
 PACKAGE_TARNAME='onedrive'
-PACKAGE_VERSION='v2.5.0-rc1'
-PACKAGE_STRING='onedrive v2.5.0-rc1'
+PACKAGE_VERSION='v2.5.0-rc2'
+PACKAGE_STRING='onedrive v2.5.0-rc2'
 PACKAGE_BUGREPORT='https://github.com/abraunegg/onedrive'
 PACKAGE_URL=''
 
@@ -1219,7 +1219,7 @@ if test "$ac_init_help" = "long"; then
   # Omit some internal or obsolete options to make the list less imposing.
   # This message is too long to be a string in the A/UX 3.1 sh.
   cat <<_ACEOF
-\`configure' configures onedrive v2.5.0-rc1 to adapt to many kinds of systems.
+\`configure' configures onedrive v2.5.0-rc2 to adapt to many kinds of systems.
 
 Usage: $0 [OPTION]... [VAR=VALUE]...
 
@@ -1280,7 +1280,7 @@ fi
 
 if test -n "$ac_init_help"; then
   case $ac_init_help in
-     short | recursive ) echo "Configuration of onedrive v2.5.0-rc1:";;
+     short | recursive ) echo "Configuration of onedrive v2.5.0-rc2:";;
    esac
   cat <<\_ACEOF
 
@@ -1393,7 +1393,7 @@ fi
 test -n "$ac_init_help" && exit $ac_status
 if $ac_init_version; then
   cat <<\_ACEOF
-onedrive configure v2.5.0-rc1
+onedrive configure v2.5.0-rc2
 generated by GNU Autoconf 2.69
 
 Copyright (C) 2012 Free Software Foundation, Inc.
@@ -1410,7 +1410,7 @@ cat >config.log <<_ACEOF
 This file contains any messages produced by compilers while
 running configure, to aid debugging if configure makes a mistake.
 
-It was created by onedrive $as_me v2.5.0-rc1, which was
+It was created by onedrive $as_me v2.5.0-rc2, which was
 generated by GNU Autoconf 2.69.  Invocation command line was
 
   $ $0 $@
@@ -2162,7 +2162,7 @@ fi
 
 
 
-PACKAGE_DATE="March 2024"
+PACKAGE_DATE="April 2024"
 
 
 
@@ -3159,7 +3159,7 @@ cat >>$CONFIG_STATUS <<\_ACEOF || ac_write_fail=1
 # report actual input values of CONFIG_FILES etc. instead of their
 # values after options handling.
 ac_log="
-This file was extended by onedrive $as_me v2.5.0-rc1, which was
+This file was extended by onedrive $as_me v2.5.0-rc2, which was
 generated by GNU Autoconf 2.69.  Invocation command line was
 
   CONFIG_FILES    = $CONFIG_FILES
@@ -3212,7 +3212,7 @@ _ACEOF
 cat >>$CONFIG_STATUS <<_ACEOF || ac_write_fail=1
 ac_cs_config="`$as_echo "$ac_configure_args" | sed 's/^ //; s/[\\""\`\$]/\\\\&/g'`"
 ac_cs_version="\\
-onedrive config.status v2.5.0-rc1
+onedrive config.status v2.5.0-rc2
 configured by $0, generated by GNU Autoconf 2.69,
   with options \\"\$ac_cs_config\\"
 

configure.ac

@@ -9,7 +9,7 @@ dnl - commit the changed files (configure.ac, configure)
 dnl - tag the release
 
 AC_PREREQ([2.69])
-AC_INIT([onedrive],[v2.5.0-rc1], [https://github.com/abraunegg/onedrive], [onedrive])
+AC_INIT([onedrive],[v2.5.0-rc2], [https://github.com/abraunegg/onedrive], [onedrive])
 AC_CONFIG_SRCDIR([src/main.d])
 
 

docs/application-config-options.md

@@ -206,7 +206,7 @@ _**Description:**_ This setting controls the timeout duration, in seconds, for w
 
 _**Value Type:**_ Integer
 
-_**Default Value:**_ 240
+_**Default Value:**_ 60
 
 _**Config Example:**_ `data_timeout = "300"`
 

docs/install.md

@@ -31,6 +31,7 @@ Only the current release version or greater is supported. Earlier versions are n
 | Ubuntu 20.04                    | [onedrive](https://packages.ubuntu.com/focal/onedrive)                       |<a href="https://packages.ubuntu.com/focal/onedrive"><img src="https://repology.org/badge/version-for-repo/ubuntu_20_04/onedrive.svg?header=" alt="Ubuntu 20.04 package" width="46" height="20"></a> |❌|✔|✔|✔| **Note:** Do not install from Ubuntu Universe as the package is obsolete and is not supported<br><br>For a supported application version, it is recommended that for Ubuntu that you install from OpenSuSE Build Service using the Ubuntu Package Install [Instructions](ubuntu-package-install.md) |
 | Ubuntu 22.04                    | [onedrive](https://packages.ubuntu.com/jammy/onedrive)                       |<a href="https://packages.ubuntu.com/jammy/onedrive"><img src="https://repology.org/badge/version-for-repo/ubuntu_22_04/onedrive.svg?header=" alt="Ubuntu 22.04 package" width="46" height="20"></a> |❌|✔|✔|✔| **Note:** Do not install from Ubuntu Universe as the package is obsolete and is not supported<br><br>For a supported application version, it is recommended that for Ubuntu that you install from OpenSuSE Build Service using the Ubuntu Package Install [Instructions](ubuntu-package-install.md) |
 | Ubuntu 23.04                    | [onedrive](https://packages.ubuntu.com/lunar/onedrive)                       |<a href="https://packages.ubuntu.com/lunar/onedrive"><img src="https://repology.org/badge/version-for-repo/ubuntu_23_04/onedrive.svg?header=" alt="Ubuntu 23.04 package" width="46" height="20"></a> |❌|✔|✔|✔| **Note:** Do not install from Ubuntu Universe as the package is obsolete and is not supported<br><br>For a supported application version, it is recommended that for Ubuntu that you install from OpenSuSE Build Service using the Ubuntu Package Install [Instructions](ubuntu-package-install.md) |
+| Ubuntu 24.04                    | [onedrive](https://packages.ubuntu.com/noble/onedrive)                       |<a href="https://packages.ubuntu.com/noble/onedrive"><img src="https://repology.org/badge/version-for-repo/ubuntu_24_04/onedrive.svg?header=" alt="Ubuntu 24.04 package" width="46" height="20"></a> |❌|✔|✔|✔| **Note:** Do not install from Ubuntu Universe as the package is obsolete and is not supported<br><br>For a supported application version, it is recommended that for Ubuntu that you install from OpenSuSE Build Service using the Ubuntu Package Install [Instructions](ubuntu-package-install.md) |
 | Void Linux                      | [onedrive](https://voidlinux.org/packages/?arch=x86_64&q=onedrive)           |<a href="https://voidlinux.org/packages/?arch=x86_64&q=onedrive"><img src="https://repology.org/badge/version-for-repo/void_x86_64/onedrive.svg?header=" alt="Void Linux x86_64 package" width="46" height="20"></a>|✔|✔|❌|❌| |
 
 ## Building from Source - High Level Requirements
@@ -61,7 +62,7 @@ Ubuntu Linux 18.x LTS reached the end of its five-year LTS window on May 31th 20
 ### Dependencies: Debian 9
 Debian 9 reached the end of its five-year support window on June 30th 2022 and is no longer supported.
 
-### Dependencies: Ubuntu 20.x -> Ubuntu 23.x / Debian 10 -> Debian 12 - x86_64
+### Dependencies: Ubuntu 20.x -> Ubuntu 24.x / Debian 10 -> Debian 12 - x86_64
 These dependencies are also applicable for all Ubuntu based distributions such as:
 *   Lubuntu
 *   Linux Mint

docs/ubuntu-package-install.md

@@ -171,6 +171,7 @@ If required, review the table below based on your 'lsb_release' information to p
 | Ubuntu 22.10 / Kinetic    | Use [Ubuntu 22.10](#distribution-ubuntu-2210) instructions below |
 | Ubuntu 23.04 / Lunar      | Use [Ubuntu 23.04](#distribution-ubuntu-2304) instructions below |
 | Ubuntu 23.10 / Mantic     | Use [Ubuntu 23.10](#distribution-ubuntu-2310) instructions below |
+| Ubuntu 24.04 / Noble      | Use [Ubuntu 24.04](#distribution-ubuntu-2404) instructions below |
 
 > [!IMPORTANT]
 > If your Linux distribution and release is not in the table above, you have 2 options:
@@ -423,6 +424,32 @@ Run: `sudo apt install --no-install-recommends --no-install-suggests onedrive`
 #### Step 5: Read 'Known Issues' with these packages
 Read and understand the [known issues](#known-issues-with-installing-from-the-above-packages) with these packages below, taking any action that is needed.
 
+### Distribution: Ubuntu 24.04
+The packages support the following platform architectures:
+|  i686  | x86_64 | ARMHF | AARCH64 |
+|:----:|:------:|:-----:|:-------:|
+|❌|✔|❌|✔|
+
+#### Step 1: Add the OpenSuSE Build Service repository release key
+Add the OpenSuSE Build Service repository release key using the following command:
+```text
+wget -qO - https://download.opensuse.org/repositories/home:/npreining:/debian-ubuntu-onedrive/xUbuntu_24.04/Release.key | gpg --dearmor | sudo tee /usr/share/keyrings/obs-onedrive.gpg > /dev/null
+```
+
+#### Step 2: Add the OpenSuSE Build Service repository
+Add the OpenSuSE Build Service repository using the following command:
+```text
+echo "deb [arch=$(dpkg --print-architecture) signed-by=/usr/share/keyrings/obs-onedrive.gpg] https://download.opensuse.org/repositories/home:/npreining:/debian-ubuntu-onedrive/xUbuntu_24.04/ ./" | sudo tee /etc/apt/sources.list.d/onedrive.list
+```
+
+#### Step 3: Update your apt package cache
+Run: `sudo apt-get update`
+
+#### Step 4: Install 'onedrive'
+Run: `sudo apt install --no-install-recommends --no-install-suggests onedrive`
+
+#### Step 5: Read 'Known Issues' with these packages
+Read and understand the [known issues](#known-issues-with-installing-from-the-above-packages) with these packages below, taking any action that is needed.
 
 ## Known Issues with Installing from the above packages
 

src/clientSideFiltering.d

@@ -30,6 +30,13 @@ class ClientSideFiltering {
 		this.appConfig = appConfig;
 	}
 
+	~this() {
+		object.destroy(appConfig);
+		object.destroy(paths);
+		object.destroy(fileMask);
+		object.destroy(directoryMask);
+	}
+
 	// Initialise the required items
 	bool initialise() {
 		// Log what is being done

src/config.d

@@ -61,17 +61,17 @@ class ApplicationConfig {
 	// HTTP Struct items, used for configuring HTTP()
 	// Curl Timeout Handling
 	// libcurl dns_cache_timeout timeout
-	immutable int defaultDnsTimeout = 60;
+	immutable int defaultDnsTimeout = 60; // in seconds
 	// Connect timeout for HTTP|HTTPS connections
 	// Controls CURLOPT_CONNECTTIMEOUT
-	immutable int defaultConnectTimeout = 10;
-	// Default data timeout for HTTP
+	immutable int defaultConnectTimeout = 10; // in seconds
+	// Default data timeout for HTTP operations
 	// curl.d has a default of: _defaultDataTimeout = dur!"minutes"(2);
-	immutable int defaultDataTimeout = 240;
+	immutable int defaultDataTimeout = 60; // in seconds
 	// Maximum time any operation is allowed to take
 	// This includes dns resolution, connecting, data transfer, etc.
 	// Controls CURLOPT_TIMEOUT
-	immutable int defaultOperationTimeout = 3600;
+	immutable int defaultOperationTimeout = 3600; // in seconds
 	// Specify what IP protocol version should be used when communicating with OneDrive
 	immutable int defaultIpProtocol = 0; // 0 = IPv4 + IPv6, 1 = IPv4 Only, 2 = IPv6 Only
 	// Specify how many redirects should be allowed
@@ -682,11 +682,22 @@ class ApplicationConfig {
 		}
 
 		auto file = File(filename, "r");
-		scope(exit) file.close();
-		scope(failure) file.close();
-
+		string lineBuffer;
+
+		scope(exit) {
+			file.close();
+			object.destroy(file);
+			object.destroy(lineBuffer);
+		}
+
+		scope(failure) {
+			file.close();
+			object.destroy(file);
+			object.destroy(lineBuffer);
+		}
+
 		foreach (line; file.byLine()) {
-			string lineBuffer = stripLeft(line).to!string;
+			lineBuffer = stripLeft(line).to!string;
 			if (lineBuffer.empty || lineBuffer[0] == ';' || lineBuffer[0] == '#') continue;
 			auto c = lineBuffer.matchFirst(configRegex);
 			if (c.empty) {