-
-
Notifications
You must be signed in to change notification settings - Fork 850
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync Issue: Key not found: fileSystemInfo when syncing shared folders #11
Comments
Thanks for letting me know. Also for future reference please can you format your post with backticks ` for log entries as it makes it easier to read. Can you advise what timezone your in so I can schedule a WebEx and work out what is going on. |
Thanks for investigating this. I was meant to but think i made bold tags instead - not been my day! Having had some time to think, I recently added a first shared folder to my onedrive account a few days ago - Sadly the logging I output doesn't add a timestamp so I cannot determine exactly when this started to happen (it runs on a cron every 4 hours) |
There is the default log file in the user home directory or /var/log/onedrive you can check.
Please send an email to support@mynas.com.au and I will send a WebEx invite. Please indicate your preference for morning / evening as I am based in Melbourne, Australia. |
That helps - I can confirm that the error started right after I added the shared folder to my OneDrive. I've just sent an email to you - should be obvious it's from me! |
Update for tracking - 'Key not found: fileSystemInfo' resolved offline, now a new error of 'remoteItem' objects are not syncing when adding a shared folder to OneDrive |
I'm experiencing this issue as well on with office365 home plan. I'm attaching the error here though it almost identical to what @ChessDragon136 got
|
@yonjah The work around at the moment is to removed the shared folders which were 'added to my OneDrive' as that is the root cause. I am working on a fix currently to ensure shared folders correctly work.
The log file will be in /var/log/onedrive/ or in your user home directory depending on file system permissions & what user you are running the client as. |
Can you please test e7267e5 to validate that it resolves your issue? I have tested the code locally and Shared Folders now sync correctly as expected. |
I'm still getting the error.
I ran with -v this time -
|
Output with nicer layout
|
Thanks for your work towards this issue. When I first compiled your code and ran it, all files and folders within the root of the Shared Folder were downloaded/created, but then I hit the message: "Remote change discarded - not in --single-directory scope" - Sync.d applyDifferences 423 No further error messages / any logging at all was outputted. The number of times this message was replicated does equate to the number of files / folders that were missing from the sync. As i have a small break am I right in thinking that it has not been correctly picked up in line 393? I subsequently re-added the OneDrive Item logging and reran but all that was outputted was the below:
And currently, I have made a backup up the items database, removed it, removed all the downloaded items from the root of the onedrive shared folder (so its back to how it was on the first run) and am now re-running (just in case) - It will take a while so if anything is different from the above here I'll let you know. Edit - No additional useful logging, and same issue as the first run. Let me know if there is anything else I can do. |
This is the json response I'm getting that causes the error I mentioned {"@odata.type":"#microsoft.graph.driveItem","cTag":"a...A","eTag":"a...1","fileSystemInfo":{"createdDateTime":"2016-05-30T11:48:56.373Z","lastModifiedDateTime":"2016-05-30T11:48:56.373Z"},"folder":{"childCount":0,"view":{"sortBy":"name","sortOrder":"ascending","viewType":"thumbnails"}},"id":"B...1!2...9","name":"sharedFolder"} |
In reality you should only be hitting that if the 'change' on OneDrive is not part of the scope to sync. If you are not using --single-directory to sync, your change should be flagged as either a root folder or be accepted as per the logic on line 395.
You are getting this as the change being presented does not have this key element - which is weird as each change should have that key. Can you add the following in at the following line:
This will then give all the changes that OneDrive is presenting. If you can run with that change in verbose mode, then send the output to support@mynas.com.au I can look at that later today. |
I have posted a further fix specifically for the When testing, make sure that you remove the Can you also test again using the latest code & ensure that you remove the |
@yonjah |
@ChessDragon136 |
Fix is incomplete / causes undesired side effects elsewhere. Will be backing out the changes this resolution implemented. |
Are you able to help testing the following? Clone the latest git master & then manually apply following patch before I sync this in:
|
@abraunegg I'll try to test it soon |
@abraunegg Ok this is where I admit my naivety of Git here and ask how do I do this? I removed and cloned the latest onedrive "git clone https://github.com/abraunegg/onedrive" However, this errors out stating file or folder does not exist. (for both onedrive.d and sync.d) |
@abraunegg I coudn't apply the patch. @ChessDragon136 I think you should apply the patch when your in the src folder. |
It was late at night for me & and didn't want to foul up 'master' - just created a branch for this issue |
I have tested this against OneDrive Business & OneDrive Personal: https://github.com/abraunegg/onedrive/tree/Issue-%2311-and-%2317
Can you help test? |
Any update on being able to test the brach listed above for this issue resolution? |
Sorry for the delay. Items seem to be working fine for me, but in the log I have a few new messages that I don't think I've seen before, none look critical but just in case... The items database was removed before sync
|
@abraunegg Sorry I didn't have time to test it. |
What should the correct values be here for that data - the local or the remote value? Depending on when / how it was uploaded - OneDrive sets the Last Modified Time to equal the file creation time on OneDrive - which is counter intuative. In the client code, it makes a patch call to set the last modified time of the file on OneDrive to equal that of the local file. It could be in the quasi 'fixed' state when this case was originally resolved & before #17 was raised, that the last modified timestamps got screwed up. When you re-run the client - do those messages return for the same items, or are they cleared up? No problem - if you can test ASAP so that I can get this merged into master & correctly resolved |
I've run some more tests and subsequent runs do not produce the messages - At this point i'm willing to put this down to using multiple builds over the last few days through fixing these issues and ignore it! |
Any update from you side? The patches have been confirmed not to re-introduce issue described in #17, & @ChessDragon136 you mentioned that the patch is working as intended so far. I am keen to get this merged in via #26 to close out the functionality loss from the original skilion version. |
Not sure when I'll be able to properly test it.
If everyone else test it to be ok it's probably better to merge it than
wait for me.
…On Sun., 17 Jun. 2018, 05:36 abraunegg, ***@***.***> wrote:
@ChessDragon136 <https://github.com/ChessDragon136> @yonjah
<https://github.com/yonjah>
Any update from you side? The patches have been confirmed not to
re-introduce issue described in #17
<#17>, & @ChessDragon136
<https://github.com/ChessDragon136> you mentioned that the patch is
working as intended so far.
I am keen to get this merged in via #26
<#26> to close out the
functionality loss from the original skilion version.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#11 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABvrnYUqqcBQNjP6cKlxpua5w5F-OUHBks5t9Xp2gaJpZM4UZDgX>
.
|
Resolved with 17e5138 |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Hi,
I have been using skilion / your onedrive tool for a long time with no issues, but i have checked my recent logs to see that it has not been working correctly.
I have cloned the latest version today, logged out and back in but the issue persists. Have not performed a resync as it is approx 400GB.. It takes a long time on my NAS.
I run using the command: /root/onedrive/onedrive --synchronize --download --confdir /root/.config/onedrive
If you need me to provide anything else please let me know.
Thanks,
The Verbose version:
The text was updated successfully, but these errors were encountered: