onedrive --no-remote-delete doesn't seem to work as expected

[simon57nz]

Bug Report Details

Describe the bug
After installing onedrive all works well except that when I run
onedrive --synchronize --no-remote-delete -- upload-only
after removing a local folder the folder was immediately removed from OneDrive.

Application and Operating System Details:

• OS: Linux tui 4.4.138-59-default Fix config folder. #1 SMP Mon Jun 18 13:48:42 UTC 2018 (f0b8f6b) x86_64 x86_64 x86_64 GNU/Linux
• Application version: onedrive v2.0.2-23-ge922a7d
• DMD or LDC compiler version dmd --version or ldmd2 --version

To Reproduce
Steps to reproduce the behavior if not causing an application crash:

1. Copy Folder to OneDrive folder
2. Run onedrive --synchronise
3. Delete Folder
4. Run onedrive --synchronize --no-remote-delete -- upload-only
5. Folder on OneDrive is deleted

Responses are :
Initializing the Synchronization Engine ...
Syncing changes from local path only - NOT syncing data changes from OneDrive ...
Deleting item from OneDrive: Tui/Liturgy

If issue is replicated by a specific 'file' or 'path' please archive the file and path tree & email to support@mynas.com.au

Complete Verbose Log Output
A clear and full log of the problem. Please use 3 ` characters to format log output to make it easier to read. See https://guides.github.com/features/mastering-markdown/ for more details.

Screenshots
If applicable, add screenshots to help explain your problem.

Additional context
Add any other context about the problem here.

Bug Report Checklist

• Detailed description
• Reproduction steps (if applicable)
• Verbose Log Output

[abraunegg]

Please can you provide the full command line you used.

The --no-remote-delete only is applied when using --upload-only

[simon57nz]

I am editing the report at present, amazingly fast reply from you. onedrive --synchronize --no-remote-delete -- upload-only Simon

…

On 13 August 2018 at 10:08, abraunegg ***@***.***> wrote: Please can you provide the full command line you used. The --no-remote-delete only is applied when using --upload-only — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#118 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AYj9AyZkTpQ8NyU3dp5Zgqwvg8aF8fVZks5uQKd6gaJpZM4V5tHa> .

-- Rgds, Simon Moseley

[simon57nz]

Currently working on getting more details of the output messages for you, but the syncronizing is taking longer than yesterday.

…

On 13 August 2018 at 10:11, Simon Moseley ***@***.***> wrote: I am editing the report at present, amazingly fast reply from you. onedrive --synchronize --no-remote-delete -- upload-only Simon On 13 August 2018 at 10:08, abraunegg ***@***.***> wrote: > Please can you provide the full command line you used. > > The --no-remote-delete only is applied when using --upload-only > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <#118 (comment)>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/AYj9AyZkTpQ8NyU3dp5Zgqwvg8aF8fVZks5uQKd6gaJpZM4V5tHa> > . > -- Rgds, Simon Moseley

-- Rgds, Simon Moseley

[abraunegg]

Can you help validate PR #119 to resolve your issue:

git clone https://github.com/abraunegg/onedrive.git
cd onedrive
git fetch origin pull/119/head:pr119
git checkout pr119
make
make install

Local validation testing:

./onedrive --version
onedrive v2.1.0-5-g7dffced
./onedrive --synchronize --verbose --upload-only --no-remote-delete
Loading config ...
Using Config Dir: /root/.config/onedrive
No config file found, using defaults
Initializing the OneDrive API ...
Opening the item database ...
All operations will be performed in: /root/OneDrive
Initializing the Synchronization Engine ...
Account Type: personal
Default Drive ID: 66d53be8a5056eca
Default Root ID: 66D53BE8A5056ECA!101
Remaining Free Space: 5271641600
Fetching details for OneDrive Root
OneDrive Root exists in the database
Syncing changes from local path only - NOT syncing data changes from OneDrive ...
Uploading differences of .
Processing root
The directory has not changed
Processing myfile.tar.gz
The file has not changed
Processing testdir
The directory has been deleted locally
Skipping remote directory delete as --upload-only & --no-remote-delete configured
Uploading new items of .

[simon57nz]

output.txt

Now works as expected, Thank You
Output in txt file

[simon57nz]

Thank you for the help.

…

On 13 August 2018 at 10:59, abraunegg ***@***.***> wrote: Can you help validate PR #119 <#119> to resolve your issue: git clone https://github.com/abraunegg/onedrive.git cd onedrive git fetch origin pull/119/head:pr119 git checkout pr119 make make install — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#118 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AYj9A5KPY1mNgeapGw5I0VIE9QDgnaRWks5uQLNfgaJpZM4V5tHa> .

-- Rgds, Simon Moseley

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.