File download fails if the file is marked as malware in OneDrive

[Jojuh]

Bug Report Details

Describe the bug
If the file is marked as possible malware in OneDrive for Business, the file download fails in the synchronization, preventing further actions.

Application and Operating System Details:

• OS: Linux jojuh-pc 4.4.0-131-generic Asynchronous operation #157-Ubuntu SMP Thu Jul 12 15:51:36 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
• Application version: onedrive v2.1.2
• OneDrive Account Type: OneDrive for Business (Office365 Business)
• DMD64 D Compiler v2.081.1

To Reproduce
Steps to reproduce the behavior if not causing an application crash:

1. Have file marked malware in OneDrive for Business folders (for example EICAR as eicar.com)
2. Run onedrive --synchronize
3. Tries to download the file three times, then fails with error "No such file or directory", cannot skip/continue to other files

Complete Verbose Log Output

juha@jojuh-pc ~ $ onedrive --synchronize --verbose
Loading config ...
Using Config Dir: /home/juha/.config/onedrive
No config file found, using defaults
Initializing the OneDrive API ...
Opening the item database ...
All operations will be performed in: /home/juha/OneDrive
Initializing the Synchronization Engine ...
Account Type: business
Default Drive ID: b!TQCdbdAI60KhQhKcssKuwdJ3RNnKuKRKnwgsjL4FeRSoPW59h23QT4Hn-pbQzx2d
Default Root ID: 01UKNUVNN6Y2GOVW7725BZO354PWSELRRZ
Remaining Free Space: 1097104622077
Fetching details for OneDrive Root
OneDrive Root exists in the database
Syncing changes from OneDrive ...
Applying changes of Path ID: 01UKNUVNN6Y2GOVW7725BZO354PWSELRRZ
The local item is unsynced, renaming
Downloading file eicar.com ... done.
eicar.com: No such file or directory
Syncing changes from OneDrive ...
Applying changes of Path ID: 01UKNUVNN6Y2GOVW7725BZO354PWSELRRZ
The local item is unsynced, renaming
Downloading file eicar.com ... done.
eicar.com: No such file or directory
Syncing changes from OneDrive ...
Applying changes of Path ID: 01UKNUVNN6Y2GOVW7725BZO354PWSELRRZ
The local item is unsynced, renaming
Downloading file eicar.com ... done.
std.file.FileException@/usr/include/dmd/phobos/std/file.d(1554): eicar.com: No such file or directory
----------------
/usr/include/dmd/phobos/std/file.d:274 @trusted bool std.file.cenforce!(bool).cenforce(bool, scope const(char)[], scope const(char)*, immutable(char)[], ulong) [0x572930]
/usr/include/dmd/phobos/std/file.d:263 @safe void std.file.setTimes!(immutable(char)[]).setTimes(immutable(char)[], std.datetime.systime.SysTime, std.datetime.systime.SysTime) [0x5820c6]
src/sync.d:681 void sync.SyncEngine.downloadFileItem(itemdb.Item, immutable(char)[]) [0x5b44cc]
src/sync.d:600 void sync.SyncEngine.applyNewItem(itemdb.Item, immutable(char)[]) [0x5b3ecf]
src/sync.d:574 void sync.SyncEngine.applyDifference(std.json.JSONValue, immutable(char)[], bool) [0x5b3d7b]
src/sync.d:437 void sync.SyncEngine.applyDifferences(immutable(char)[], const(char)[]) [0x5b3297]
src/sync.d:201 void sync.SyncEngine.applyDifferences() [0x5b2385]
src/main.d:421 void main.performSync(sync.SyncEngine, immutable(char)[], bool, bool, bool) [0x597ca6]
src/main.d:289 _Dmain [0x59752f]

Additional context
Have not tried with OneDrive Personal account, is there a malware detection present. Can provide any further information if necessary.

[abraunegg]

@Jojuh
Can you help validate the following PR which should resolve your issue:

git clone https://github.com/abraunegg/onedrive.git
cd onedrive
git fetch origin pull/155/head:pr155
git checkout pr155
make
make install

Local validation of fix:

Loading config ...
Using Config Dir: /root/.config/onedrive
No config file found, using defaults
Initializing the OneDrive API ...
Opening the item database ...
All operations will be performed in: /root/OneDrive
Initializing the Synchronization Engine ...
Account Type: business
Default Drive ID: <redacted>
Default Root ID: <redacted>
Remaining Free Space: 1099259905301
Fetching details for OneDrive Root
OneDrive Root does not exist in the database. We need to add it.
Added OneDrive Root to the local database
Syncing changes from OneDrive ...
Applying changes of Path ID: <redacted>
Downloading file eicar/eicar_com.zip ... ERROR: MALWARE DETECTED IN FILE - DOWNLOAD SKIPPED
Downloading file eicar/eicar.com ... ERROR: MALWARE DETECTED IN FILE - DOWNLOAD SKIPPED
Downloading file eicar/eicarcom2.zip ... ERROR: MALWARE DETECTED IN FILE - DOWNLOAD SKIPPED
Uploading differences of .
Processing root
The directory has not changed
Processing eicar
The directory has not changed
Processing Document.docx
The file has not changed
Uploading new items of .
Applying changes of Path ID: <redacted>

[Jojuh]

Yes, it seems to skip the file correctly now:

juha@jojuh-pc ~ $ onedrive --synchronize
Initializing the Synchronization Engine ...
Syncing changes from OneDrive ...
Creating directory: test
Downloading file test/eicar.com ... ERROR: MALWARE DETECTED IN FILE - DOWNLOAD SKIPPED

[abraunegg]

PR #155 merged

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.