Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong config directory is used if $XDG_CONFIG_HOME is present #181

Closed
marcusball opened this issue Sep 19, 2018 · 3 comments
Closed

Wrong config directory is used if $XDG_CONFIG_HOME is present #181

marcusball opened this issue Sep 19, 2018 · 3 comments
Assignees
Labels
Bug Something isn't working Fixed
Milestone

Comments

@marcusball
Copy link

marcusball commented Sep 19, 2018

Bug Report Details

Describe the bug
The environment variable XDG_CONFIG_HOME defines the path to the main directory for configuration files (ex: /home/username/.config), however, it is currently being used as the homePath so when it is set, onedrive uses /home/username/.config/.config/onedrive as the config directory rather than /home/username/.config/onedrive.

Application and Operating System Details:

  • OS: Linux archlabs 4.18.6-arch1-1-ARCH Fix config folder. #1 SMP PREEMPT Wed Sep 5 11:54:09 UTC 2018 x86_64 GNU/Linux
  • Application version: onedrive v2.1.2-5-g53cbc8f
  • OneDrive Account Type: Personal
  • DMD version: DMD64 D Compiler v2.082.0

To Reproduce

  • Set XDG_CONFIG_HOME to the base directory in which the onedrive config directory should be stored.
  • Onedrive will use the path $XDG_CONFIG_HOME/.config/onedrive rather than $XDG_CONFIG_HOME/onedrive.

Complete Verbose Log Output

2018-Sep-19 12:01:13.2023002 Loading config ...
2018-Sep-19 12:01:13.2023763 Using Config Dir: /home/marcus/.config/.config/onedrive
2018-Sep-19 12:01:13.2024817 No config file found, using defaults
@abraunegg
Copy link
Owner

Thanks for finding this and submitting a PR too

@abraunegg abraunegg added Bug Something isn't working PR Provided - Needs Testing labels Sep 20, 2018
@abraunegg abraunegg self-assigned this Sep 20, 2018
abraunegg pushed a commit that referenced this issue Sep 20, 2018
* Fix incorrectly nested configDir in X11 systems
@abraunegg
Copy link
Owner

PR merged after local testing

@abraunegg abraunegg added this to the 2.1.3 milestone Oct 3, 2018
@lock
Copy link

lock bot commented Jan 5, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Jan 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug Something isn't working Fixed
Projects
None yet
Development

No branches or pull requests

2 participants