Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Ability to set --disable-download-validation from env var #2559

Closed
OscarVanL opened this issue Dec 7, 2023 · 4 comments
Closed
Labels
Feature Request Feature Request | Enhancement Request Implemented
Milestone

Comments

@OscarVanL
Copy link

Is your feature request related to a problem? Please describe.

I'd like to set --disable-download-validation as I am having the Sharepoint “enrichment” bug, but I deploy via a docker container. It does not appear this option is assignable via env var according to this table or the source code.

Describe the solution you'd like

Expose this config item via an environment variable

Describe alternatives you've considered

I could probably use a config file instead

Additional context

No response

@OscarVanL OscarVanL added the Feature Request Feature Request | Enhancement Request label Dec 7, 2023
@abraunegg
Copy link
Owner

@OscarVanL
Unfortunately no more change is going to be made for any v2.4.x code or Docker image. I will look at exposing this for v2.5.x

Your best solution currently is to add this to your config file.

Given that your prior discussion was around upload only, disabling this SharePoint issue for downloads is not going to have any effect. Please read the following documentation items:

@abraunegg abraunegg added this to the v2.5.x milestone Dec 7, 2023
@OscarVanL
Copy link
Author

OscarVanL commented Dec 8, 2023

Thanks abraunegg, the download verification issue I was facing was because I wanted to redownload the contents of onedrive first.

Interestingly, I do not actually need to set disable_upload_validation to upload new files successfully. However, I do need to set disable_download_validation to successfully download older files.

For somer reason it seems in my scenario I only need to disable validation in one direction.

@abraunegg
Copy link
Owner

@OscarVanL
This has been implemented in 'alpha-5'. Please can you test 'alpha-5' by building a custom Docker build and testing the new applicable options:

image

The 'alpha-5' details can be found here: #2585

The updated documentation can be found here: https://github.com/abraunegg/onedrive/blob/onedrive-v2.5.0-alpha-5/docs/docker.md

@abraunegg
Copy link
Owner

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

Repository owner locked as resolved and limited conversation to collaborators Jan 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Feature Request Feature Request | Enhancement Request Implemented
Projects
None yet
Development

No branches or pull requests

2 participants