Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ebuild for Gentoo users. #101

Merged
merged 2 commits into from
Aug 7, 2018
Merged

ebuild for Gentoo users. #101

merged 2 commits into from
Aug 7, 2018

Conversation

zigford
Copy link

@zigford zigford commented Aug 6, 2018

Just thought I'd offer this ebuild I've been using to allow installations and upgrades via portage on Gentoo.

@abraunegg
Copy link
Owner

Thanks for the PR request.

With Gentoo - does it use / support DMD 2.081.1? The older DMD (< DMD 2.081.1) should not really be used to compile the onedrive client.

@abraunegg abraunegg self-requested a review August 6, 2018 20:04
@zigford
Copy link
Author

zigford commented Aug 6, 2018

2.081.1 is available but currently in testing. I’ve been using it compiled against 2.078. What sort of issues would I expect? I can modify this ebuild to have a hard depency on 2.081.1.

@abraunegg
Copy link
Owner

There were some changes in what modules are brought in (such as stdlib.d) which is is depreciated in DMD versions < 2.081.1 but removed in 2.081.1. Whilst this codebase has that fixed so it should build on < 2.081.1, all my test scripts on Travis CI are using either DMD 2.081.1 or LDC 1.10.0.

It would be good to ensure that the Gentoo emerge script is at least building against the the same DMD version the code is being tested against for consistency. If 2.081.1 is in 'testing' and not fully validated for Gentoo - no problem.

Copy link
Owner

@abraunegg abraunegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

readme changes OK, however I dont have a Gentoo background to validate ebuild script. Assuming here that this works as intended

@abraunegg abraunegg merged commit b2270ee into abraunegg:master Aug 7, 2018
@lock
Copy link

lock bot commented Jan 5, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Jan 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants