Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix application crash when calculating the path length due to invalid UTF characters #1193

Merged
merged 5 commits into from Dec 20, 2020

Conversation

abraunegg
Copy link
Owner

@abraunegg abraunegg commented Dec 18, 2020

  • Fix application crash when calculating the path length due to invalid UTF characters

… UTF characters

* Fix application crash when calculating the path length due to invalid UTF characters
@abraunegg abraunegg changed the title Fix application crash when calculating the path length due to invalid UTF characters WIP: Fix application crash when calculating the path length due to invalid UTF characters Dec 18, 2020
@abraunegg
Copy link
Owner Author

@norbusan
It looks like that #493 did not fix the issue, as it was never user validated.

@abraunegg abraunegg added this to the v2.4.9 milestone Dec 18, 2020
@abraunegg abraunegg changed the title WIP: Fix application crash when calculating the path length due to invalid UTF characters Fix application crash when calculating the path length due to invalid UTF characters Dec 19, 2020
* The has path has disappeared check needs to be first
* Fix up comments
norbusan
norbusan previously approved these changes Dec 20, 2020
Copy link
Collaborator

@norbusan norbusan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, invalid UTF8 sequences ...

* Update comments
@abraunegg abraunegg merged commit 771a932 into master Dec 20, 2020
@abraunegg abraunegg deleted the fix-issue-1192 branch December 20, 2020 20:27
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators May 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid UTF-8 sequence (at index 1) Invalid UTF-8 sequence (at index 1)
2 participants