Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search all distinct drive id's rather than just default drive id for --get-file-link (Issue #1227) #1230

Merged
merged 2 commits into from Jan 20, 2021
Merged

Search all distinct drive id's rather than just default drive id for --get-file-link (Issue #1227) #1230

merged 2 commits into from Jan 20, 2021

Conversation

abraunegg
Copy link
Owner

  • Add new DB query to return distinct driveId's from database
  • Use all distinct drive ID's to query if path is in-sync with OneDrive before attempting to retrieve the item file link from OneDrive

@abraunegg
Search all distinct drive id's rather than just default drive id for …
f83d2c5 
…--get-file-link

* Add new DB query to return distinct driveId's from database
* Use all distinct drive ID's to query if path is in-sync with OneDrive before attempting to retreive the item file link from OneDrive
@abraunegg
Copy link
Owner Author

With a file that has been synced to OneDrive Business Shared Folder:

Without PR:

./onedrive --confdir '~/.config/onedrive-business/' --get-file-link './Top Folder/asdfasdfs.txt'
Configuration file successfully loaded
Configuring Global Azure AD Endpoints
File has not been synced with OneDrive: ./Top Folder/asdfasdfs.txt

With PR:

./onedrive --confdir '~/.config/onedrive-business/' --get-file-link './Top Folder/asdfasdfs.txt'
Configuration file successfully loaded
Configuring Global Azure AD Endpoints
https://<redacted>/Documents/Top%20Folder/asdfasdfs.txt

@abraunegg abraunegg added this to the v2.4.10 milestone Jan 19, 2021
@abraunegg abraunegg linked an issue Jan 19, 2021 that may be closed by this pull request
Support to get share link of Business Shared Folder #1227
Closed
norbusan
norbusan reviewed Jan 19, 2021
View reviewed changes
src/itemdb.d Show resolved Hide resolved
@abraunegg abraunegg merged commit 6b0b6a6 into master Jan 20, 2021
@abraunegg abraunegg deleted the fix-issue-1227 branch January 20, 2021 08:47
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators May 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@norbusan norbusan norbusan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.4.10
Development

Successfully merging this pull request may close these issues.

Support to get share link of Business Shared Folder
2 participants
@abraunegg @norbusan