Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add processing dots for all long running operation #2606

Merged
merged 4 commits into from
Jan 26, 2024

Conversation

JC-comp
Copy link

@JC-comp JC-comp commented Jan 25, 2024

This PR adds processing dots to console for db consistency check and file system walk.

Changes

  • Add helper for processing log with message and dots
  • Set a rate limit of 1 second for processing dots.
  • Showing processing dots during
    1. db consistency check
    2. file system walk.

@abraunegg
Copy link
Owner

@JC-comp
Works well, except for one line:

Reading configuration file: /home/alex/.config/onedrive/config
The option 'min_notify_changes' has been depreciated and will be ignored. Please read the updated documentation and update your client configuration to remove this option.
The option 'force_http_2' has been depreciated and will be ignored. Please read the updated documentation and update your client configuration to remove this option.
Configuration file successfully loaded

ERROR: Unable to create /var/log/onedrive
ERROR: Please manually create '/var/log/onedrive' and set appropriate permissions to allow write access for your user to this location.
ERROR: The requested client activity log will instead be located in your users home directory

Deleting the saved application sync status ...
Forcing client to use IPv4 connections only
Configuring Global Azure AD Endpoints
Fetching items from the OneDrive API for Drive ID: 66d53be8a5056eca ...................................................................
Processing 26116 applicable changes and items received from Microsoft OneDrive ....................................
Downloading file random_25k_files/random_files/RFKMPmTlIq6ciKDHFeaL7qUclEHVtpO0/file104.data ... done
Syncing this OneDrive Personal Shared Folder: OneDrive - Constanze
Fetching items from the OneDrive API for Drive ID: bc7d88ec1f539dcf ..
Processing 5 applicable changes and items received from Microsoft OneDrive .
Performing a database consistency and integrity check on locally stored data ..
Scanning the local file system '~/OneDrive' for new data to upload ..Performing a last examination of the most recent online data within Microsoft OneDrive to complete the reconciliation process
Fetching items from the OneDrive API for Drive ID: 66d53be8a5056eca ..
No additional changes or items that can be applied were discovered while processing the data received from Microsoft OneDrive
Syncing this OneDrive Personal Shared Folder: OneDrive - Constanze
Fetching items from the OneDrive API for Drive ID: bc7d88ec1f539dcf .
No additional changes or items that can be applied were discovered while processing the data received from Microsoft OneDrive

Sync with Microsoft OneDrive is complete

This line:

Scanning the local file system '~/OneDrive' for new data to upload ..Performing a last examination of the most recent online data within Microsoft OneDrive to complete the reconciliation process

So something in the PR, post the file system walk for new data, is not terminating the 'dots' at the end of the file system walk.

Please can you investigate and fix.

@JC-comp
Copy link
Author

JC-comp commented Jan 26, 2024

So something in the PR, post the file system walk for new data, is not terminating the 'dots' at the end of the file system walk.

Corrected the improper use of appending dots instead of a closing newline after the file system walk.

@abraunegg
Copy link
Owner

So something in the PR, post the file system walk for new data, is not terminating the 'dots' at the end of the file system walk.

Corrected the improper use of appending dots instead of a closing newline after the file system walk.

Thanks

@abraunegg abraunegg merged commit 1a3724d into abraunegg:onedrive-v2.5.0-alpha-5 Jan 26, 2024
@JC-comp JC-comp deleted the upload-logging branch January 27, 2024 00:33
@abraunegg
Copy link
Owner

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

Repository owner locked and limited conversation to collaborators Feb 3, 2024
@abraunegg abraunegg added this to the v2.5.0 milestone Feb 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants