Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error handling for version check #2615

Merged
merged 1 commit into from
Feb 3, 2024

Conversation

JC-comp
Copy link

@JC-comp JC-comp commented Jan 30, 2024

This PR resolves the issue where progress crashes when the GitHub API is unavailable.

DEBUG: Shutting down HTTP engine as successfully reached OneDrive Login Service
DEBUG: Checking Application Version ...
DEBUG: CurlException: Unable to query GitHub for latest release - HTTP request returned status code 403 ()
DEBUG: Failure scope was called
DEBUG: Running performStandardExitProcess due to: failureScope
DEBUG: Shutdown Client Side Filtering instance
DEBUG: Shutdown Application Configuration instance
DEBUG: Setting ALL Class Objects to null due to failure scope
DEBUG: Exit scope was called
DEBUG: Running performStandardExitProcess due to: exitScope
DEBUG: Application exit
std.json.JSONException@std/json.d(687): Key not found: latestTag
----------------
/home/alan/dlang/dmd-2.105.3/linux/bin64/../../src/phobos/std/exception.d:518 pure @safe noreturn std.exception.bailOut!(std.json.JSONException).bailOut(immutable(char)[], ulong, scope const(char)[]) [0x55e33d82e604]
??:? pure @safe inout(std.json.JSONValue)* std.exception.enforce!(std.json.JSONException).enforce!(inout(std.json.JSONValue)*).enforce(inout(std.json.JSONValue)*, lazy const(char)[], immutable(char)[], ulong) [0x55e33d987f9c]
??:? inout pure ref @safe inout(std.json.JSONValue) std.json.JSONValue.opIndex(return scope immutable(char)[]) [0x55e33d934421]
src/util.d:780 void util.checkApplicationVersion() [0x55e33d88991d]
src/main.d:410 _Dmain [0x55e33d7660b8]

@JC-comp JC-comp changed the title Add error handling for version check Fix error handling for version check Jan 30, 2024
@abraunegg abraunegg merged commit f773549 into abraunegg:onedrive-v2.5.0-alpha-5 Feb 3, 2024
@JC-comp JC-comp deleted the githubAPI branch February 4, 2024 04:47
@abraunegg abraunegg added this to the v2.5.0 milestone Feb 11, 2024
@abraunegg
Copy link
Owner

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

Repository owner locked and limited conversation to collaborators Feb 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants