Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supress processing dots in verbose mode #2622

Merged
merged 2 commits into from
Feb 4, 2024

Conversation

JC-comp
Copy link

@JC-comp JC-comp commented Feb 4, 2024

This PR resolves #2621 that processing dots are not suppressed in verbose mode.

Changes

  • Only show processing dots with info logging level

src/sync.d Outdated
@@ -4012,9 +4021,15 @@ class SyncEngine {
if (isDir(path)) {
if (!appConfig.surpressLoggingOutput) {
if (!cleanupLocalFiles) {
addProcessingLogHeaderEntry("Scanning the local file system '" ~ logPath ~ "' for new data to upload");
addProcessingLogHeaderEntry(
"Scanning the local file system '" ~ logPath ~ "' for new data to upload",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please dont split this across multiple lines

Please fix for all of these

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed with 3c2a83f

@abraunegg abraunegg linked an issue Feb 4, 2024 that may be closed by this pull request
@abraunegg abraunegg merged commit 1630ae3 into abraunegg:onedrive-v2.5.0-alpha-5 Feb 4, 2024
@JC-comp JC-comp deleted the verbose branch February 4, 2024 04:46
@abraunegg abraunegg added this to the v2.5.0 milestone Feb 11, 2024
@abraunegg
Copy link
Owner

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

Repository owner locked and limited conversation to collaborators Feb 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: PR 2606 now generates inconsistent log output in --verbose mode
2 participants