-
-
Notifications
You must be signed in to change notification settings - Fork 849
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
autoconf based build system #287
Conversation
6d33a5a
to
46f1119
Compare
46f1119
to
f71c020
Compare
f71c020
to
378a6f8
Compare
@norbusan |
I am working on updating this branch for the current sources, I am not overly happy anyway with autoconf ;-) |
@abraunegg can we decide for either autoconf or meson/ninja, so that I don't have to update both? The meson/ninja would leave the current Makefile as is, and allow for two ways of building, either directly using make or using meson. The autoconf branch would drop the Makefile completely and require the What do you prefer? |
Having mainly always used |
Ok, I will update the PR according to the current master, lots of changes have happened ;-) |
@norbusan If you are OK with this being in v2.3.3 then this is good to merge |
Fine with me waiting for 2.4.0. Let us release 2.3.3 at some point with the current fixes, and then merge 2.4.0 in the next run. |
@abraunegg Do we merge this now, or do you plan some other release before 3.4? |
@norbusan |
Fine with wating for some emergencies! Let's wait till tomorrow. Please approve now or later, when it is convenient for you (merged master) |
Thanks |
* Update default Makefile with systemd service file changes introduced by #287 when not calling ./configure
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Convert the build system to autoconf (without automake). By dropping the (anyway nearly superfluous) automake dependency the build errors should be gone, and the
Makefile
is much more readable and close to the current status. This is an updated and improved version of #284Release management:
configure.ac
autoconf
: this will generateconfigure
,onedrive.1
,pacman/PKGBUILD
,spec/onedrive.spec
(these are all files in the git repo and thus need to be updated)This way, new releases can be used as downloaded from the auto-generated release packages at github.
Currently supported features/items (no change concerning the previous pull request)
dmd
andldmd2
(in this order)DCFLAGS
default to-w -g -O
but can be overridden via env variablespkg-config
, libs are automatically generated--enable-notifications
, which searches automatically forlibnotify
usingpkg-config
pkg-config --variable=systemdsystemunitdir systemd
etc.pkg-config
is not available, one can usecurl_LIBS
andsqlite_LIBS
to pass in the necessary libs, same fornotify_LIBS
--with-systemdsystemunitdir=no
or--with-systemduserunitdir=no
pacman/PKGBUILD
andspec/onedrive.spec
, and the version number in the man page is also automatically replacedversion
file is now generated from the program version if no.git
directory is foundFeatures from the current Makefile not carried over:
pkg-config
callsIncomplete items