Strengthen data preservation checks & update how bypass preservation is set

[abraunegg]

• Strengthen bypass data preservation variable checks

[abraunegg]

output when using --resync & locally modified file

./onedrive --confdir '~/.config/onedrive-personal/' --synchronize --verbose --resync
Using Config Dir: /home/alex/.config/onedrive-personal/
Configuration file successfully loaded
Deleting the saved status ...
Initializing the OneDrive API ...
Opening the item database ...
All operations will be performed in: /home/alex/OneDrivePersonal
Application version: v2.4.1-14-gf9c3ccc
Account Type: personal
Default Drive ID: 66d53be8a5056eca
Default Root ID: 66D53BE8A5056ECA!101
Remaining Free Space: 5368706448
Fetching details for OneDrive Root
OneDrive Root does not exist in the database. We need to add it.
Added OneDrive Root to the local database
Initializing the Synchronization Engine ...
Syncing changes from OneDrive ...
Applying changes of Path ID: 66D53BE8A5056ECA!101
Processing 6 OneDrive items to ensure consistent local state
The local item has a different modified time 2020-May-25 21:30:55Z remote is 2020-May-25 21:26:19Z
The local item has a different hash
Local item does not exist in local database - replacing with file from OneDrive - failed download?
The local item is out-of-sync with OneDrive, renaming to preserve existing file and prevent data loss due to --resync: corona_information -> corona_information-centos7full
Downloading file corona_information ... done.
Number of items from OneDrive to process: 1
Uploading differences of .
Processing root
The directory has not changed
Processing random_videos
The directory has not changed
Processing random_images
The directory has not changed
Processing random_files
The directory has not changed
Processing corona_information
The file has not changed
Uploading new items of .
Uploading new file ./corona_information-centos7full ... done.
Remaining free space on OneDrive: 5368703756
Applying changes of Path ID: 66D53BE8A5056ECA!101
Number of items from OneDrive to process: 2

[abraunegg]

@norbusan
Not that I was able to trigger the issue as per #930 - however the code was trying to do a 'string' query rather than a 'bool' query which is now fixed. Also found an 'edge' case that makes sense which is now fixed - where if --resync is issued, and local file is 'newer' we should rename that file rather than have it overwritten just in case.

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.