Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update USAGE.md #968

Merged
merged 4 commits into from Jun 27, 2020
Merged

Update USAGE.md #968

merged 4 commits into from Jun 27, 2020

Conversation

gilsedawk
Copy link
Contributor

wrong path mentioned in docs to unit files... or at least on my centos 7 (the unit files end up in: /usr/lib/systemd/system instead of /usr/lib/systemd/user)
this is default for user unit files for centos 7.

not sure if the install script takes this into account?

in that case it should maybe be mentioned that this path may differ per distro?

wrong path mentioned in docs to unit files... or at least on my centos 7 (the unit files end up in: /usr/lib/systemd/system instead of /usr/lib/systemd/user)
this is default for user unit files for centos 7.

not sure if the install script takes this into account?

in that case it should maybe be mentioned that this path may differ per distro?
@abraunegg
Copy link
Owner

@gilsedawk

wrong path mentioned in docs to unit files... or at least on my centos 7 (the unit files end up in: /usr/lib/systemd/system instead of /usr/lib/systemd/user)
this is default for user unit files for centos 7.

not sure if the install script takes this into account?

in that case it should maybe be mentioned that this path may differ per distro?

The path in the documentation is correct - at least for all except CentOS / RHEL, as CentOS / RHEL does not utilise 'user systemd' configurations.

The makefile / install process takes care of this to ensure the files are in the right place:

ifeq ($(RHEL),1)
	$(INSTALL) -m 0644 $(system_unit_files) $(DESTDIR)$(systemdsystemunitdir)
	$(INSTALL) -m 0644 $(user_unit_files) $(DESTDIR)$(systemdsystemunitdir)
else
	$(INSTALL) -m 0644 $(system_unit_files) $(DESTDIR)$(systemdsystemunitdir)
	$(INSTALL) -m 0644 $(user_unit_files) $(DESTDIR)$(systemduserunitdir)
endif

A better update to the readme (as your current PR, whilst correct for CentOS, is now making it incorrect for everyone else) would be to detail where the files can be found, based on the OS.

If you can make your PR reflect that, that would be greatly appreciated.

@abraunegg abraunegg self-requested a review June 25, 2020 08:00
Copy link
Owner

@abraunegg abraunegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment / feedback for changes needed

gilsedawk and others added 3 commits June 26, 2020 08:49
* Update usage.md to specify both user systemd locations
@abraunegg abraunegg merged commit 35e1800 into abraunegg:master Jun 27, 2020
@abraunegg abraunegg added this to the v2.4.3 milestone Jun 27, 2020
@gilsedawk gilsedawk deleted the patch-1 branch June 28, 2020 22:22
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators May 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants