-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework on voicehint process #613
Comments
An other point for this rework is the handling of two near turn instructions left/right. The different results come from the minimal distance table: |
The last announcement before turns should be very short and clear.
|
Two new samples from #625:
|
During my research for this issue I found further inconsistencies - like the number 2 above. |
Sample 2 above:
I didn't use a correction on this for now - just to keep the results comparable. But I used a new logic in post process. left = old The source is located in my repo Before I go on with the 'left' problem and the exclusion of the straight voicehints in nearby situation, I like to hear what you are thinking about. Is this a way it could go? |
I did not expect the u-turn hint in the second last example and the two straight hints in the last example, but overall I think this is the way to go. However I don't understand the source from just looking at it. Maybe we should document the logic somewhere? |
@afischerdev seems like a working solution:
|
@devemux86 |
A Beta version of Cruiser is available where I post process the turn instructions to fix the nearby "continue": (this works in Cruiser code on top of any routing service) |
@devemux86 |
More examples of routes missing a "turn left" instruction were reported: |
Next version for voice hints The first step was to start a new transportMode - announced here #544 To remenber the old rules from doc
There are two steps of control for the voice hint list:
Results for trekking samples above: For a closer look: testtrack0.trekking_old.gpx.txt testtrack0.car_old.gpx.txt testtrack0.hiking_old.gpx.txt The samples uses all the same coordinates Darmstadt to Heidelberg The source for this you find as before here So have fun the next days. |
For the new issue #664 I changed the voicehint calculation on roundabouts. |
It seems the post process for voicehint generation needs a rework.
Please see doc for voicehint for the current rules.
Related to this discussion in Cruiser forum we have some smaller irritation for the users (I hope I got it correct):
The rule
keep continue when bad way is on higher prio
is working fine. But it has its side effects.Are there any other examples that should be revised as well?
The text was updated successfully, but these errors were encountered: