Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with voicehints on roundabouts #664

Closed
afischerdev opened this issue Jan 30, 2024 · 5 comments
Closed

Problem with voicehints on roundabouts #664

afischerdev opened this issue Jan 30, 2024 · 5 comments
Milestone

Comments

@afischerdev
Copy link
Collaborator

In some situations the voicehint calculation brings up an error for roundabouts.
Please see this exsample.
When you switch the turnInstructionMode to OsmAnd and export a gpx file, you will find voicehints like this

...
<turn>RNLB-2</turn>
<turn-angle>-74</turn-angle>
...

The server is not running on the last version 1.7.3, but also the last version has this issue. This can be verified with the app.

afischerdev added a commit to afischerdev/brouter that referenced this issue Jan 30, 2024
This was referenced Jan 30, 2024
@EssBee59
Copy link
Collaborator

EssBee59 commented Feb 2, 2024

Hello,

Yes, I had also some times problem with roundabouts..
But just for understanding:
For the first roundabout in the example I get:

image

Where is the problem, "take exit-2 is for me Ok"?

@devemux86
Copy link
Contributor

devemux86 commented Feb 2, 2024

@EssBee59

RNLB is a roundabout left instruction, where all roundabouts in the example are right (RNDB).

@EssBee59
Copy link
Collaborator

EssBee59 commented Feb 2, 2024

thank for the explanation..
OK, I never had this problem...
Strange is, the behavior seems to depend on the profile: Using my profiles I get RNDB, not RNLB

(to test, you can use profile=racebike-verylowtraffic or &profile=trekking_SB
then set the parameter assign turnInstructionMode = 3 AND assign turnInstructionRoundabouts = true because I deactivated this option)

@afischerdev
Copy link
Collaborator Author

There are more problems inside roundabout.
To make it visible here an export with timode=4

     $turn$ RNDB2;    11;  1.521596; 42.506310;   186; 22(1)24$
     $turn$ RNDB2;    26;  1.521980; 42.504736;   474; 24(2)26 (168)6$
     $turn$ RNDB1;    47;  1.527428; 42.505226;   363; 26(14)26$
     $turn$ RNLB2;    63;  1.531711; 42.505927;   215; 26(9)26$
     $turn$ RNDB1;    75;  1.534200; 42.506397;   221; 26(-5)26$
     $turn$ RNDB2;    88;  1.536711; 42.506933;   208; 26(-4)26$
     $turn$    TR;   109;  1.537869; 42.508118;   224; 6(87)6 (1)6$

First you see the wrong RNLB command - as discussed before. You can also see the RNDB2 command has two exits but only one angle and its an angle of 1 - nothing very meaningful.
So here is an additonel rework on roundabout problems.

     $turn$ RNDB2;    11;  1.521596; 42.506310;   186; 22(-113)24 (-27)24$
     $turn$ RNDB2;    26;  1.521980; 42.504736;   474; 24(-156)26 (-18)26$
     $turn$ RNDB2;    47;  1.527428; 42.505226;   363; 26(-76)26 (-49)26$
     $turn$ RNDB2;    63;  1.531711; 42.505927;   183; 26(-89)26 (-36)26$
     $turn$ RNDB1;    75;  1.534200; 42.506397;   221; 26(-95)26$
     $turn$ RNDB2;    88;  1.536711; 42.506933;   208; 26(-131)26 (-37)26$
     $turn$    TR;   109;  1.537869; 42.508118;   224; 6(87)6 (1)6$

And a small graphic output for the situation here
P11 P26 P47 P63 P75 P88 P109

afischerdev added a commit to afischerdev/brouter that referenced this issue Feb 20, 2024
@afischerdev
Copy link
Collaborator Author

And the other way round - see this route

     $turn$ RNLB3;     8;  1.073063; 51.279021;   520; 26(201)26 (29)26 (137)26$
     $turn$ RNLB2;    41;  1.074407; 51.275272;   505; 26(114)28 (25)28$
     $turn$ RNLB2;    64;  1.080900; 51.275623;   244; 28(119)28 (15)28$
     $turn$ RNLB1;    76;  1.083646; 51.276879;   327; 28(116)28$
     $turn$  TSLL;    92;  1.085867; 51.279418;   601; 28(-29)28 (125)28$
     $turn$ RNLB1;   123;  1.089801; 51.283412;   209; 28(23)28$
     $turn$ RNLB3;   134;  1.087313; 51.284198;   941; 28(204)28 (36)28 (117)28$
     $turn$ RNLB2;   182;  1.097251; 51.289263;   164; 28(128)28 (38)28$

P8 P41 P64 P76 P92 P123 P134 P182

@afischerdev afischerdev added this to the Version 1.7.4 milestone Mar 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants