Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repeat button is not visible on retrace - window doesn't resize down #1303

Closed
abitrolly opened this issue Apr 30, 2018 · 2 comments
Closed
Labels

Comments

@abitrolly
Copy link

Repeat button in the case of failed retrace is off screen limits, and impossible to reach as window doesn't resize down vertically.

image

@xsuchy xsuchy added the bug label Jun 25, 2018
@ernestask
Copy link
Collaborator

ernestask commented Oct 16, 2018

This technically comes from libreport.

I’d say this is more a fundamental design issue than a technical one, as GtkNotebook will ask for an allocation equal to its largest page[0] (i.e. pages are homogeneous), so that means that some page of the wizard has a lot going on inside. Moreover, the message at the bottom only makes it worse, given that it’s added dynamically and causes the toplevel to grow. I’m no designer, but such messages should be placed in the content area, or at the very least be presented as a modal dialog.

I’m not sure which page could be acting out in this case, but throwing more scrolled windows at it might work around this.

Or I’m completely wrong about it, and nothing makes sense.

--

[0] - https://gitlab.gnome.org/GNOME/gtk/blob/05b11e9a5bc91a7681f25106f9d2f198bde3d025/gtk/gtknotebook.c#L2342

@abitrolly
Copy link
Author

abrt/libreport#539

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants