Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

object destructuring #47

Closed
odino opened this issue Dec 21, 2018 · 0 comments
Closed

object destructuring #47

odino opened this issue Dec 21, 2018 · 0 comments
Labels
enhancement New feature or request
Milestone
1.1.x

Comments

@odino
Copy link
Collaborator

odino commented Dec 21, 2018

No description provided.

@odino odino added this to the future milestone Dec 21, 2018
@odino odino added the enhancement New feature or request label Dec 21, 2018
@odino odino modified the milestones: cauldron, 1.1 Jan 14, 2019
@odino odino assigned odino and unassigned odino Jan 30, 2019
odino added a commit that referenced this issue Jan 31, 2019
@odino
Allow, destructuring hashes, closes #47
d10beb4 
```
myhash = {"some": "thing", "over": "the rainbow", "x": "y"}
some, over = myhash
echo(some) # "thing"
```

@ntwrick I had to revert one of your changes we introduced
when adding error lines etc. When we evaluate null literals
we always return a new object, and this means that when
you compare `null == null` that is `false` as they're 2
different objects. For now I reverted that line you changed
but maybe we could also think of adding a special case to
handle `==` with nulls. Problem is, you'd have to add another
special case for `!=` so I think it's probably easier to just
reuse the same object for nulls...what do you think?
odino added a commit that referenced this issue Jan 31, 2019
@odino
Allow, destructuring hashes, closes #47
dad668d 
```
myhash = {"some": "thing", "over": "the rainbow", "x": "y"}
some, over = myhash
echo(some) # "thing"
```

@ntwrick I had to revert one of your changes we introduced
when adding error lines etc. When we evaluate null literals
we always return a new object, and this means that when
you compare `null == null` that is `false` as they're 2
different objects. For now I reverted that line you changed
but maybe we could also think of adding a special case to
handle `==` with nulls. Problem is, you'd have to add another
special case for `!=` so I think it's probably easier to just
reuse the same object for nulls...what do you think?
odino added a commit that referenced this issue Feb 2, 2019
@odino
Allow, destructuring hashes, closes #47
d16a8d7 
```
myhash = {"some": "thing", "over": "the rainbow", "x": "y"}
some, over = myhash
echo(some) # "thing"
```

@ntwrick I had to revert one of your changes we introduced
when adding error lines etc. When we evaluate null literals
we always return a new object, and this means that when
you compare `null == null` that is `false` as they're 2
different objects. For now I reverted that line you changed
but maybe we could also think of adding a special case to
handle `==` with nulls. Problem is, you'd have to add another
special case for `!=` so I think it's probably easier to just
reuse the same object for nulls...what do you think?
@odino odino closed this as completed Feb 2, 2019
odino added a commit that referenced this issue Feb 2, 2019
@odino
Allow, destructuring hashes, closes #47
16ab5bf 
```
myhash = {"some": "thing", "over": "the rainbow", "x": "y"}
some, over = myhash
echo(some) # "thing"
```

@ntwrick I had to revert one of your changes we introduced
when adding error lines etc. When we evaluate null literals
we always return a new object, and this means that when
you compare `null == null` that is `false` as they're 2
different objects. For now I reverted that line you changed
but maybe we could also think of adding a special case to
handle `==` with nulls. Problem is, you'd have to add another
special case for `!=` so I think it's probably easier to just
reuse the same object for nulls...what do you think?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
1.1.x
Development

No branches or pull requests
1 participant
@odino