Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implements reverse() as a string method #310

Merged
merged 9 commits into from
Dec 22, 2019

Conversation

sysread
Copy link
Contributor

@sysread sysread commented Dec 16, 2019

A simple implementation of #306.

Jeff Ober added 8 commits December 16, 2019 14:03
validateVarArgs' argument specification now uses a format that supports
multiple argument signatures, each of whose arguments are in turn a list
of supported types. For example, to achieve:

  foo(string, [string|number])
  foo(string)

Your argument would be:

  {
    {{STRING_OBJ}, {STRING_OBJ, NUMBER_OBJ}},
    {{STRING_OBJ}},
  }

Matching is done in order, giving priority to specs by lower index.

Additionally, validateVarArgs is now smart enough to figure out the
minimum and maximum number of arguments on its own.

When validateVarArgs fails to match a spec, it will return an error with
a usage string showing the alternate calling signatures. On success, it
will return the index of the matched signature as the second return
value.
@sysread sysread changed the base branch from master to 1.9.x December 16, 2019 19:50
Copy link
Collaborator

@odino odino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This (the last 2 commits) is also good to go -- port it to 1.10 and we can merge 🙂

@sysread sysread changed the base branch from 1.9.x to 1.10.x December 21, 2019 20:57
@sysread
Copy link
Contributor Author

sysread commented Dec 21, 2019

Base branch changed to 1.10.x.

@odino odino merged commit 8ab9b60 into abs-lang:1.10.x Dec 22, 2019
@odino
Copy link
Collaborator

odino commented Dec 22, 2019

Thanks a bunch!

odino added a commit that referenced this pull request Jan 2, 2020
* Use a more flexible structure for the spec argument to validateVarArgs

validateVarArgs' argument specification now uses a format that supports
multiple argument signatures, each of whose arguments are in turn a list
of supported types. For example, to achieve:

  foo(string, [string|number])
  foo(string)

Your argument would be:

  {
    {{STRING_OBJ}, {STRING_OBJ, NUMBER_OBJ}},
    {{STRING_OBJ}},
  }

Matching is done in order, giving priority to specs by lower index.

Additionally, validateVarArgs is now smart enough to figure out the
minimum and maximum number of arguments on its own.

When validateVarArgs fails to match a spec, it will return an error with
a usage string showing the alternate calling signatures. On success, it
will return the index of the matched signature as the second return
value.

* arr.join() now defaults to an empty string as glue when no argument is specfied

* validateVarArgs' error message should begin with 'Usage:'

* Remove debug line

* split() defaults to a single space

* Update docs for join(), split()

* Add support for calling 'reverse()' as a method on a string

* Add documentation

Co-authored-by: Alessandro Nadalin <alessandro.nadalin@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants