Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize StrJoin with tuple without user defined formatter #1672

Closed
wants to merge 2 commits into from

Conversation

MBkkt
Copy link
Contributor

@MBkkt MBkkt commented May 11, 2024

#1671

Unfortunately the benchmarks can't be used with CMake and I don't have time to fix that or figure out how to use Bazel.

@derekmauro
Copy link
Member

It may take me a few days to run some tests to make sure this doesn't break anything, but initially I'd say this is good work.

For reference, to build the benchmark:
bazel build -c opt absl/strings:str_join_benchmark

Then to run the benchmark:
bazel-bin/absl/strings/str_join_benchmark

Although it looks like the existing benchmark doesn't cover this case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants