Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix stacktrace on aarch64 architecture. Fixes #805 #827

Merged
merged 2 commits into from
Nov 5, 2020
Merged

Fix stacktrace on aarch64 architecture. Fixes #805 #827

merged 2 commits into from
Nov 5, 2020

Conversation

romange
Copy link
Contributor

@romange romange commented Oct 22, 2020 •
edited
Loading

Fixes #805

@google-cla google-cla bot added the cla: yes label Oct 22, 2020
@romange romange mentioned this pull request Oct 22, 2020
Closed
@romange
Copy link
Contributor Author

romange commented Oct 28, 2020

Hi @derekmauro . can you please take a look?

@derekmauro
Copy link
Member

@EmployedRussian's review is good enough for me. @rogeeff, can you please finish merging this?

@derekmauro
Copy link
Member

@suertreus - Can you please merge this?

@suertreus suertreus merged commit 731852f into abseil:master Nov 5, 2020
absl-federation-github pushed a commit that referenced this pull request Nov 5, 2020
@suertreus
Export of internal Abseil changes
e96d496 
--
76c5eb1cf346a1a64e0a5e2edf032546d600075a by Andy Getzendanner <durandal@google.com>:

Fix stacktrace on aarch64 architecture. Fixes #805

Import of #827

PiperOrigin-RevId: 340886173

--
28f48f7bcadd4681854cddb0a7736d26d7dab000 by Andy Getzendanner <durandal@google.com>:

Some attribute cleanups in and around statusor:
* mark statusor_internal::Helper::Crash ABSL_ATTRIBUTE_NORETURN
* add ABSL_INTERNAL_UNREACHABLE to ABSL_INTERNAL_LOG when severity is FATAL
* create ABSL_INTERNAL_UNREACHABLE to wrap __builtin_unreachable and __assume(0)
* use ABSL_ATTRIBUTE_NONNULL instead of __builtin_unreachable in statusor_internal::PlacementNew (https://godbolt.org/z/n691fa)

PiperOrigin-RevId: 340868438

--
33905d1d2d01eb6f81b04abaf24170bfebb6df09 by Andy Getzendanner <durandal@google.com>:

moved deleted functions to public for better compiler errors.

Import of #828

PiperOrigin-RevId: 340863976

--
5e502222dfc3f5a0ef146535a9e16c743b005092 by Jorg Brown <jorg@google.com>:

ConvertibleToStringView wastes a lot of cycles initializing members just to reset them immediately after. Only initialize the string storage when needed. This makes StrSplit() 0-30% faster depending on the use case.

PiperOrigin-RevId: 340732039
GitOrigin-RevId: 76c5eb1cf346a1a64e0a5e2edf032546d600075a
Change-Id: I2ba1f717c4eaad384cd0a22694fd05f9e6a2d8fa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derekmauro derekmauro derekmauro approved these changes

@EmployedRussian EmployedRussian EmployedRussian approved these changes

Assignees

@suertreus suertreus

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

failure handler crashes on aarch64
4 participants
@romange @derekmauro @EmployedRussian @suertreus