Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redefining a type should throw a warning or an error #466

Closed
knewter opened this issue Dec 6, 2017 · 2 comments
Closed

Redefining a type should throw a warning or an error #466

knewter opened this issue Dec 6, 2017 · 2 comments

Comments

@knewter
Copy link

knewter commented Dec 6, 2017

Presently, if we define a type twice the last definition wins. It would be nice if instead we could blow up at compile time, either with a warning or (preferably) an error, because it's never going to be what someone wants to do. I wasted an hour debugging until I found that I'd double-defined a type with the same name :-\ Not the fault of absinthe, but it seems like it would be nice to save all the "future-me"s that time :)

@bruce bruce added this to the Schema Definition Refactor milestone Dec 6, 2017
@benwilson512
Copy link
Contributor

This works in 1.5 / master

@ckruse
Copy link

ckruse commented Feb 18, 2019

Great news! I wasted a couple of hours debugging this ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants