Type System Directives SDL rendering #1010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
binaryseed
commented
Dec 28, 2020
| @@ -44,7 +44,8 @@ defmodule Absinthe.Phase.Schema.ApplyDeclaration do | |||
| %{ | |||
| schema_definition | |||
| | type_definitions: | |||
| Enum.map(schema_definition.type_definitions, &maybe_mark_root(&1, root_mappings)) | |||
| Enum.map(schema_definition.type_definitions, &maybe_mark_root(&1, root_mappings)), | |||
| schema_declaration: declaration | |||
There was a problem hiding this comment.
Storing the schema_declaration so it can be used by SDL rendering - it might contain directives that we want to render
binaryseed
commented
Dec 28, 2020
| @@ -613,7 +613,7 @@ defmodule Absinthe.Schema do | |||
| def to_sdl(schema) do | |||
| pipeline = | |||
| schema | |||
| |> Absinthe.Pipeline.for_schema() | |||
| |> Absinthe.Pipeline.for_schema(prototype_schema: schema.__absinthe_prototype_schema__) | |||
There was a problem hiding this comment.
This was needed to get the directive definitions in place when applied with a prototype schema
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part of #1003
This PR ensures that directives applied to types (ie: Type System Directives) are correctly rendered in SDL output
After this, we can add support for these directives actually showing up in the
Absinthe.Type.*structs