Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for interface implementing other interfaces #1012

Merged
merged 11 commits into from
Dec 29, 2020

Conversation

maartenvanvliet
Copy link
Contributor

Fixes #990

Adds support for interfaces implementing other interfaces according to the spec https://spec.graphql.org/draft/#sec-Interfaces.Interfaces-Implementing-Interfaces

  • added support in the parser/sdl schema
  • added support in macro schema
  • check if interfaces don't form a cycle
  • add support for rendering in the sdl

Copy link
Contributor

@benwilson512 benwilson512 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you!

@benwilson512 benwilson512 merged commit c707638 into absinthe-graphql:master Dec 29, 2020
@maartenvanvliet maartenvanvliet deleted the issues/990 branch December 29, 2020 18:17
Copy link
Contributor

@binaryseed binaryseed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great!

"""

import_sdl @sdl
# query do
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leftover lines?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, let me fix that

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Interface can now implement other interfaces
3 participants