Fix introspection bug with import_fields and input #1015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
binaryseed
changed the title
binaryseed
commented
Jan 1, 2021
| def import_fields(%def_type{} = type, types) when def_type in @can_import do | ||
| Enum.reduce(type.imports, type, fn {source, opts}, type -> | ||
| source_type = Map.fetch!(types, source) | ||
|
|
||
| rejections = Keyword.get(opts, :except, []) | ||
| rejections = Keyword.get(opts, :except, []) ++ @exclude_fields |
There was a problem hiding this comment.
I chose to always exclude __typename since the current behavior was actually causing it to be included twice for object as well as once for input_object
binaryseed
force-pushed
the
import_fields-input-__typename
branch
from
16553d0
to
d437a58
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug that would include
__typenamein aninputif it calledimport_fieldson an object.Fixes #989