Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrections on __TypeKind #1019

Merged
merged 2 commits into from
Jan 2, 2021

Conversation

binaryseed
Copy link
Contributor

@binaryseed binaryseed commented Jan 2, 2021

Followup to #1017

  • Our __TypeKind was defined with one more type (SCHEMA) than the GraphQL spec, which is now corrected
  • Absinthe.Introspection.TypeKind is now more explicit, and no longer relies on module name parsing to define itself
  • Directives aren't a Kind

@@ -94,15 +94,14 @@ defmodule Absinthe.Type.BuiltIns.Introspection do

enum :__type_kind,
values: [
:schema,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a __TypeKind

@@ -8,7 +8,6 @@ defmodule Absinthe.Type.Directive do

alias Absinthe.Type
alias Absinthe.Language
use Absinthe.Introspection.Kind
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a __TypeKind

@binaryseed binaryseed merged commit 0f3df91 into absinthe-graphql:master Jan 2, 2021
@binaryseed binaryseed deleted the type-kind-updates branch January 2, 2021 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant