Allow interface fields to reference other interfaces (#1089) #1091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerelmiller
force-pushed
the
fix-interfaces-in-interfaces
branch
from
c4ecc82
to
61c0112
Compare
jerelmiller
force-pushed
the
fix-interfaces-in-interfaces
branch
from
61c0112
to
0b62790
Compare
|
@binaryseed not sure if you're able to have a look, but I would love your input! |
|
It be cool to see this merged in soon! Looking forward to seeing this functionality. |
binaryseed
reviewed
Aug 2, 2021
| @@ -191,6 +191,18 @@ defmodule Absinthe.Phase.Schema.Validation.ObjectMustImplementInterfaces do | |||
| :ok | |||
| end | |||
|
|
|||
| defp check_covariant( | |||
| %Blueprint.TypeReference.Name{name: iface_name}, | |||
| %Blueprint.TypeReference.Name{name: type_name}, | |||
There was a problem hiding this comment.
Ahh, I suspect the difference between the SDL & DSL is that only SDL currently generates the TypeReference blueprint structs everywhere... DSL winds up with bare-atom identifiers
This is a related note from a while back: #783
There was a problem hiding this comment.
You're exactly right! Thats what I was seeing, just a bare atom in the case of the DSL.
binaryseed
approved these changes
Aug 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1089
It appears the DSL and the
import_sdldiffer in how interface types, with fields that themselves interfaces types, are compiled. When creating schemas via the DSL, compilation works as intended. I can create an interface that contains a field that is another interface type. When I do the same viaimport_sdl, compilation fails because it Absinthe thinks that the interface is not fully adhered to. This attempts to patch that behavior to ensure interface types can have fields that are themselves interfaces.To ensure this use case is valid according to the GraphQL spec, I created a minimal reproduction of this schema using GraphQL.js to validate whether the SDL or the DSL had the correct behavior. It does indeed appear that interface types are allowed as fields to other interface types.