Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert SDL Language.* structs to SDL notation #1160

Merged

Conversation

maartenvanvliet
Copy link
Contributor

Followup to #1114

Converts the schema definition language structs back to the string representation.

@kdawgwilk
Copy link
Contributor

Would this help resolve the issues like #1110 where behavior is different between SDL and macro schemas?

@maartenvanvliet
Copy link
Contributor Author

No, this just ensures that we can transform the Absinthe.Language intermediate representation to the string form. This is relevant for tooling mostly. The whole Absinthe.Language.* could be extracted to a separate package, so the lexer, parser and intermediate representation can live there and Absinthe can depend on that.

The Absinthe.Language structs are converted to Blueprint structs in the import_sdl notation. Here there are some discrepancies between the macro and sdl notation which leads to issues in the sdl renderer.

Copy link
Contributor

@benwilson512 benwilson512 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@benwilson512 benwilson512 merged commit ee32739 into absinthe-graphql:master Apr 25, 2022
@maartenvanvliet maartenvanvliet deleted the sdl_language_inspect branch April 26, 2022 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants