Fix bug in Schema.__absinthe_types__(:all) for Persistent Term #1161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -5,6 +5,7 @@ defmodule Absinthe.Type.ObjectTest do | |||
|
|
|||
| defmodule Schema do | |||
| use Absinthe.Schema | |||
| use Absinthe.Fixture | |||
There was a problem hiding this comment.
@maartenvanvliet Did this solve a warning or something?
There was a problem hiding this comment.
It causes a test failure when the tests are run with PERSISTENT_TERM=true
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small bug fix, the
Schema.__absinthe_types__(:all)list contained references instead of names in the persistent term provider. It did not affect anything afaict but it triggered an error when thetest/absinthe/type/object_test.exsused the persistent term schema provider.