Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DirectivesMustBeValid schema phase #954

Commits on Jun 26, 2020

  1. Add DirectivesMustBeValid schema phase

    I noticed in the SDL rendering output that a macro directive that did not
    specify the `on` clause would render invalid SDL.
    
    E.g.
    ```elixir
        directive :foo do
          arg :baz, :string
        end
    ```
    
    Would render in SDL
    ```
    directive @foo(baz: String) on
    ```
    
    This PR adds a phase to the schema pipeline to check whether
    the directive locations are set. I also check whether the locations
    themselves are valid.
    maartenvanvliet committed Jun 26, 2020
    Configuration menu
    Copy the full SHA
    2edc09c View commit details
    Browse the repository at this point in the history

Commits on Nov 27, 2020

  1. Configuration menu
    Copy the full SHA
    c11adfd View commit details
    Browse the repository at this point in the history