Fix double escaped back slashes in string arguments #962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattbaker
changed the title
|
@bruce any chance you can weigh in on this one? |
|
@mattbaker Thanks for submitting this. I've made a commit that removes the escape handling from the parser code, relying instead on the lexer to handle it. Tests are passing locally. Please take a look. |
|
Makes sense to me @bruce 👍 The only thing on my mind is that this may actually be a breaking change, in case that impacts how the change is released or communicated. I suspect it's rare for people to be escaping so heavily in a string, we just happen to have a couple specific cases in New Relic's API where folks are (which is for us to figure out). |
binaryseed
approved these changes
Aug 17, 2020
binaryseed
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@binaryseed suggested I just submit the branch I used to test for #961 as a PR with failing tests as an example. Happy to update the parser to remove the escape processing and add it to this PR if that's the right direction.