Allow :meta on field #973
Merged
Allow :meta on field #973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hermanverschooten
force-pushed
the
fix_meta_for_field
branch
from
c72c674
to
89e7b10
Compare
Hermanverschooten
force-pushed
the
fix_meta_for_field
branch
from
89e7b10
to
7e690bc
Compare
|
Thanks a lot for this PR @Hermanverschooten , @benwilson512 this seems to be fine, what do you think ? |
|
Looks great, thanks! |
This was referenced Sep 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned on Slack and in issue #958, inline meta does not work.
I think this add that ability back.