Fix compilation bug with persistent_term backend #982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is awesome, thank you! |
Merged
|
I think this PR is flawed, so I have a PR that fixes the original failure we were encountering absinthe-graphql/absinthe_plug#234 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a compile time bug with the
persistent_termschema backend.PopulatePersistentTerm.run/2was only getting called during compilation. So if another file changes but not the schema module, it doesn't get re-compiled and thus it's not populated - this can cause compile-time references to the schema to fail.This is fixed by populating the
persistent_termbackend upon@on_load. This also means we don't need to startup a GenServer in the user's app to populate, which paves the way for easier adoption of this in the future.@benwilson512