MG-93 - Add bootstraps charts support #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Musilah
force-pushed
the
bootstrapcharts
branch
from
c64712a
to
a5552e4
Compare
dborovcanin
force-pushed
the
dashboards
branch
5 times, most recently
from
c2d9d7a
to
e8a2028
Compare
Musilah
force-pushed
the
bootstrapcharts
branch
from
a5552e4
to
066d273
Compare
dborovcanin
force-pushed
the
dashboards
branch
from
af39137
to
d47594c
Compare
Musilah
force-pushed
the
bootstrapcharts
branch
from
c2c9ff2
to
38f8313
Compare
dborovcanin
force-pushed
the
dashboards
branch
from
2335f11
to
9b7c4dd
Compare
Musilah
force-pushed
the
bootstrapcharts
branch
from
38f8313
to
4dc1dc0
Compare
Signed-off-by: Musilah <nataleigh.nk@gmail.com>
Signed-off-by: Musilah <nataleigh.nk@gmail.com>
Signed-off-by: Musilah <nataleigh.nk@gmail.com>
Signed-off-by: Musilah <nataleigh.nk@gmail.com>
Signed-off-by: Musilah <nataleigh.nk@gmail.com>
Signed-off-by: Musilah <nataleigh.nk@gmail.com>
Signed-off-by: Musilah <nataleigh.nk@gmail.com>
Musilah
force-pushed
the
bootstrapcharts
branch
from
4dc1dc0
to
c5f3ff7
Compare
Signed-off-by: Musilah <nataleigh.nk@gmail.com>
|
Fix the height styling. There is too much unnecessary space at the bottom
|
ianmuchyri
requested changes
Feb 14, 2024
| }); | ||
| } else { |
There was a problem hiding this comment.
This only works for widgets with cards in them. For the rest with the tables and progress bar it does not work well check on that
ui/web/templates/dashboard.html
Outdated
| @@ -124,4 +132,4 @@ <h5 id="widgetsCanvasLabel">Widgets</h5> | |||
| <script src="/js/singleDashboard.js"></script> | |||
| </body> | |||
| </html> | |||
| {{ end }} | |||
| {{ end }} | |||
Signed-off-by: Musilah <nataleigh.nk@gmail.com>
Musilah
force-pushed
the
bootstrapcharts
branch
from
e326418
to
4261d90
Compare
Signed-off-by: Musilah <nataleigh.nk@gmail.com>
felixgateru
approved these changes
Feb 14, 2024
There was a problem hiding this comment.
The resizing of the widgets is still not optimal but is being handled by issue #129
ianmuchyri
approved these changes
Feb 14, 2024
dborovcanin
approved these changes
Feb 15, 2024
dborovcanin
added a commit
that referenced
this pull request
Feb 15, 2024
* NOISSUE - Add support for dashboards (#91) Signed-off-by: ianmuchyri <ianmuchiri8@gmail.com> * NOISSUE - Add placeholder to the canvas with no widget (#127) * add a widget placeholder to the dashboard Signed-off-by: ianmuchyri <ianmuchiri8@gmail.com> * remove vh-50 on nowidgetplaceholder Signed-off-by: ianmuchyri <ianmuchiri8@gmail.com> * make add widget add widgets Signed-off-by: ianmuchyri <ianmuchiri8@gmail.com> --------- Signed-off-by: ianmuchyri <ianmuchiri8@gmail.com> * NOISSUE - Fix nowidget placeholder (#150) * check items length to determine if items present Signed-off-by: ianmuchyri <ianmuchiri8@gmail.com> * remove comments Signed-off-by: ianmuchyri <ianmuchiri8@gmail.com> * fix lint error Signed-off-by: ianmuchyri <ianmuchiri8@gmail.com> --------- Signed-off-by: ianmuchyri <ianmuchiri8@gmail.com> * NOISSUE - Fix chart CSS (#154) * fix card css this will prevent the css from affecting all card elements that will be added in the future Signed-off-by: ianmuchyri <ianmuchiri8@gmail.com> * move styles to the styles file Signed-off-by: ianmuchyri <ianmuchiri8@gmail.com> * remove unused parameter in transport.go Signed-off-by: ianmuchyri <ianmuchiri8@gmail.com> --------- Signed-off-by: ianmuchyri <ianmuchiri8@gmail.com> * MG-93 - Add more Apache Echarts (#117) * add billboard.js files Signed-off-by: Musilah <nataleigh.nk@gmail.com> * add multigauge Signed-off-by: Musilah <nataleigh.nk@gmail.com> * fix gauge charts Signed-off-by: Musilah <nataleigh.nk@gmail.com> * fix: format documents Signed-off-by: Musilah <nataleigh.nk@gmail.com> * fix: size issues Signed-off-by: Musilah <nataleigh.nk@gmail.com> * capitalise line chart Signed-off-by: Musilah <nataleigh.nk@gmail.com> * fix multiple line chart tag Signed-off-by: Musilah <nataleigh.nk@gmail.com> * fix resizing Signed-off-by: Musilah <nataleigh.nk@gmail.com> * replace bbcharts Signed-off-by: Musilah <nataleigh.nk@gmail.com> * fix spelling error Signed-off-by: Musilah <nataleigh.nk@gmail.com> --------- Signed-off-by: Musilah <nataleigh.nk@gmail.com> * MG-111- Modify Chart modals (#123) * Modify chart modals Signed-off-by: felix.gateru <felix.gateru@gmail.com> * Add apperance tab to charts Signed-off-by: felix.gateru <felix.gateru@gmail.com> * Rename form inputs Signed-off-by: felix.gateru <felix.gateru@gmail.com> * Refactor code Signed-off-by: felix.gateru <felix.gateru@gmail.com> * Add spacing between nav tab and form Signed-off-by: felix.gateru <felix.gateru@gmail.com> --------- Signed-off-by: felix.gateru <felix.gateru@gmail.com> * MG-93 - Add bootstraps charts support (#122) * fix edit widgets Signed-off-by: Musilah <nataleigh.nk@gmail.com> * fix save layout Signed-off-by: Musilah <nataleigh.nk@gmail.com> * add config Signed-off-by: Musilah <nataleigh.nk@gmail.com> * fix all charts addwidget function Signed-off-by: Musilah <nataleigh.nk@gmail.com> * fix all charts save Signed-off-by: Musilah <nataleigh.nk@gmail.com> * fix resize Signed-off-by: Musilah <nataleigh.nk@gmail.com> * fix resizing Signed-off-by: Musilah <nataleigh.nk@gmail.com> * fix gauges sizes Signed-off-by: Musilah <nataleigh.nk@gmail.com> * fix height issue Signed-off-by: Musilah <nataleigh.nk@gmail.com> * remove valueandbarchart Signed-off-by: Musilah <nataleigh.nk@gmail.com> --------- Signed-off-by: Musilah <nataleigh.nk@gmail.com> --------- Signed-off-by: ianmuchyri <ianmuchiri8@gmail.com> Signed-off-by: Musilah <nataleigh.nk@gmail.com> Signed-off-by: felix.gateru <felix.gateru@gmail.com> Co-authored-by: Ian Ngethe Muchiri <100555904+ianmuchyri@users.noreply.github.com> Co-authored-by: Nataly Musilah <115026536+Musilah@users.noreply.github.com> Co-authored-by: Felix Gateru <felix.gateru@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this do?
This adds more charts from bootstrap
Which issue(s) does this PR fix/relate to?
Have you included tests for your changes?
Did you document any new/modified functionality?
Notes
The charts being added include: