Skip to content
This repository has been archived by the owner on Jun 13, 2023. It is now read-only.

abstraignore #2

Merged
merged 11 commits into from
Jun 30, 2022
Merged

abstraignore #2

merged 11 commits into from
Jun 30, 2022

Conversation

brunovcosta
Copy link
Contributor

Adding .abstraignore support

@brunovcosta brunovcosta added the WIP Work in Progress label Jun 23, 2022
@brunovcosta brunovcosta removed the WIP Work in Progress label Jun 23, 2022
felipereyel
felipereyel reviewed Jun 24, 2022
View reviewed changes
README.md Outdated Show resolved Hide resolved
felipereyel
felipereyel reviewed Jun 24, 2022
View reviewed changes
Copy link
Contributor

@felipereyel felipereyel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK to me. Just a comment on the description of the ignore.

There are some improvements like moving normalize path and others to utils or other module. But that is non impeditive.

@brunovcosta @felipereyel
Update README.md
f93a3ba 
Co-authored-by: Felipe Reyel <felipe.reyel@gmail.com>
@brunovcosta brunovcosta merged commit 1e48758 into master Jun 30, 2022
@brunovcosta brunovcosta deleted the abstraignore branch June 30, 2022 19:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@felipereyel felipereyel felipereyel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brunovcosta @felipereyel @pedrorv