Migrate acceptance tests to use destroy-app helper

[blimmer]

The next version of Ember CLI will have a new destroy app helper, similiar to the start-app helper that already exists. I want to write a migrator to help automatically move everyone over to this new syntax.

Additionally, I link to a place where users can learn how to create this helper and use it before they're able to upgrade to Ember CLI 1.13.9 (yet to be released).

[rwjblue]

Just a note: using this.application = startApp() (vs just using a local variable) was only changed a version or two ago.

If the test in question does not use this.application = startApp() (it is using application = startApp() instead), should we update the usage to the new format?

[blimmer]

@rwjblue I wonder if that should be covered in the more generic qunit transforms rather than here?

[abuiles]

@blimmer thanks for this! Probably we can add it here? The old transform was to help people migrate to QUnit 2 syntax.

[blimmer]

I just worry that that introduces pretty big scope creep to this story. Changing that would also mean that we would have to parse the rest of the file to ensure we change any other references to this.application to application to ensure we don't break people's tests. That change feels different from the goal of this formula.

That said, if you guys disagree, I can take a look at adding that functionality as time permits.

[abuiles]

@blimmer Makes sense, let's then create another formula for that? I'll merge this in and release, thank you very much!

[abuiles]

@blimmer I will hold merging and release until ember-cli gets released, @rwjblue @stefanpenner can we sync on that, ping me before release so I'll release this new command too.

[knownasilya]

Sounds like we need a min version option for commands, making the command not run if the version of Ember CLI is less then that min and giving the user a nice message.

[blimmer]

The gist I link to if the file isn't present explains how to get this functionality before the new Ember-CLI version is released. This is pretty crucial to another fix for ember-cli-mirage, and some might want to manually place the destroy-app.js helper before Ember CLI 1.13.9.

However, if the standard is to not release new ember watson before the other PR is mainlined, we can definitely stick to that behavior.

[abuiles]

@blimmer you are right, we don't need to hold this until ember-cli release.

[abuiles]

@blimmer released 0.6.6 👍 thanks!

[rwjblue]

Changing that would also mean that we would have to parse the rest of the file to ensure we change any other references to this.application to application to ensure we don't break people's tests.

Agreed, but this migration isn't helpful at all (and might actually result in errors when running tests) if this.application is not set, right?

[abuiles]

@rwjblue https://github.com/abuiles/ember-watson/pull/84/files#diff-33249e58accc9fa584dfd86ecb7b193fR71 will help avoid this issue?

[rwjblue]

@abuiles - I don't think so. Once folks update ember-cli they will have that file (so that guard will not return early), but their tests will not be using this.application.

I did try to review the transform code again, and I think my concerns are unfounded since the transform will use whatever the right hand assignment is of startApp() call (which means app = startApp(), this.foo = startApp(), etc should work fine).

[abuiles]

@rwjblue awesome! @blimmer can you confirm?

[blimmer]

Yes, the transform will work no matter what you use to store the application object. I explicitly test for it for mocha and qunit. here's the relevant code.