-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Efficient factorization of diagonal outer Hessian in convex-over-nonlinear and nonlinear least-squares costs #1024
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I went through the code and left some comments.
// hessian of outer loss function | ||
blasfeo_dpotrf_l(ny, &work->W, 0, 0, &memory->W_chol, 0, 0); | ||
// factorize hessian of outer loss function | ||
// TODO: benchmark whether sparse factorization is faster |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that now that we are only storing the diagonal as a vector it should be always more efficient.
Then we can remove this TODO.
@giaf do you agree?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it will make cost integration for medium+ sized problems much faster.
Great collaboration again 📈
ny > 4
, its diagonal Cholesky factorizationW_chol
is computed manually and stored asblasfeo_dvec
W_chol
accordingly