Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup SQP submodules - only use single evaluation point at a time #1040

Merged
merged 4 commits into from
Feb 20, 2024

Conversation

FreyJo
Copy link
Member

@FreyJo FreyJo commented Feb 16, 2024

In some places tmp_ux and ux where used in a mixed way, i.e. compute_fun of constraint modules and what was fixed in #1039

  • fixes bug when using globalization and cost computation
  • fixes bug in globalization with slacks. Constraint was evaluated with slack values from SQP iterate instead of values from the line search candidate

Implementation:

  • Removed all tmp_* pointers in SQP submodules
  • Always evaluate at ux
  • When one wants to evaluate at another iterate, these pointers have to be temporarily set to another iterate and afterwards reset to the nominal SQP iterate, as done in ocp_nlp_evaluate_merit_fun now.

@FreyJo FreyJo changed the title Add use_tmp_values flag to compute_fun Cleanup submodules - only use single evaluation point at a time Feb 19, 2024
@FreyJo FreyJo changed the title Cleanup submodules - only use single evaluation point at a time Cleanup SQP submodules - only use single evaluation point at a time Feb 19, 2024
@FreyJo FreyJo requested a review from giaf February 19, 2024 10:44
@giaf
Copy link
Collaborator

giaf commented Feb 20, 2024

It looks good!

@FreyJo FreyJo merged commit d490843 into acados:master Feb 20, 2024
5 checks passed
@FreyJo FreyJo deleted the dev_compute_fun branch February 20, 2024 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants