Matlab remove os path dependency #896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
December 2, 2022 15:07
…iable path Modified building of casadi_ext_fun library such that the gcc version configured for building mex files is used. This avoids a linking error which happens when a version of gcc different than configured for mex building is in the OS environment PATH variable.
…iable path Modified building of casadi_ext_fun library such that the gcc version configured for building mex files is used. This avoids a linking error which happens when a version of gcc different than configured for mex building is in the OS environment PATH variable.
…piling for simulation
JacobDGrunnet
commented
Dec 7, 2022
| @@ -223,6 +226,13 @@ function ocp_generate_casadi_ext_fun(model_struct, opts_struct) | |||
| % build | |||
| compile_command = sprintf('"%s" & %s', msvc_env, build_cmd); | |||
| else % gcc | |||
| %Read the mex C compiler configuration and extract the location | |||
| cCompilerConfig = mex.getCompilerConfigurations('C'); | |||
There was a problem hiding this comment.
This command is not available in Octave.
However, it seems that Octave automatically adds a path to compatible gcc version to the PATH environment variable when Octave starts, so it should be possible just to skip all of this if octave is used
FreyJo
requested changes
Dec 8, 2022
There was a problem hiding this comment.
Hi, that's good to know.
I have to admit that I don't have a Casadi compatible Octave version on my machine right now, so I can't really test it.
However, that is why we have the Github tests in place.
Can you just add some ifs to make this work for Octave?
Then the tests should also pass and I will test it for Matlab locally as well.
JacobDGrunnet
force-pushed
the
MatlabRemoveOSPathDependency
branch
from
9918857
to
59099b9
Compare
…ecting compiler in Matlab This also includes a slight cleanup as it merges two compiler checks (+1 squashed commits) Squashed commits: [fe59f9c] Matlab: Fix error when using octave introduced when automatically detecting compiler in Matlab This also includes a slight cleanup as it merges two compiler checks
JacobDGrunnet
force-pushed
the
MatlabRemoveOSPathDependency
branch
from
6d9fd18
to
884d8e2
Compare
|
Seems I fixed the remaining bug :D |
FreyJo
approved these changes
Jan 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When generating a Simulink s-function a number of c-files are compiled using the mex compilation setup and these are linked with a library containing the casadi_ext_fun. The compilation of this library does not use mex compilation, but is rather a system call directly to the compiler. For this to work it is required that the compiler used by mex is added to the OS PATH environment variable.
As we need to have another (incompatible) version of gcc in our OS PATH environment variable acados will use this incompatible gcc version to compile the cadasdi_ext_fun library and the linking will subsequently fail.