RK3 implementation and sanity check for number of RK stages of plant and model #910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…RK3. switch cases still not moved to function
acados_sim.m : modified function call to detect_dims_sim detect_dims_ocp.m : added check for erk method before num_stage check detect_dims_sim.m : added check for sim_method and num_stage
acados_sim.m : modified function call to remove opts as output detect_dims_sim.m : modified function def to remove opts as output
FreyJo
approved these changes
Jan 17, 2023
There was a problem hiding this comment.
Looks good! Thanks for the contribution!
Since there are quite a few explicit RK methods of RK3, I just wanted to note that you went for:
"Kutta's_third-order_method"
https://en.wikipedia.org/wiki/List_of_Runge%E2%80%93Kutta_methods#Kutta's_third-order_method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.