Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MEX: remove pointers to external functions in Matlab #952

Merged
merged 1 commit into from
Aug 3, 2023
Merged

MEX: remove pointers to external functions in Matlab #952

merged 1 commit into from
Aug 3, 2023

Conversation

mohammed-hababeh
Copy link
Contributor

@mohammed-hababeh mohammed-hababeh commented Aug 2, 2023 •
edited by FreyJo

Pointers were only needed to set parameters in the old interface.
Now they are internally in the solver capsule.

Removed and adapted some code in:

  • acados_mex_create.in.c
  • acados_mex_set.in.c
  • mex_solver.in.m

@FreyJo FreyJo changed the title Remove mex artifacts MEX: remove pointers to external functions in Matlab Aug 3, 2023
FreyJo
FreyJo approved these changes Aug 3, 2023
View reviewed changes
Copy link
Member

@FreyJo FreyJo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@FreyJo FreyJo merged commit d7d57d8 into acados:master Aug 3, 2023
3 checks passed
@mohammed-hababeh mohammed-hababeh deleted the remove_mex_artifacts branch August 3, 2023 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FreyJo FreyJo FreyJo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mohammed-hababeh @FreyJo