New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix buffer overflow in extract_status_code() #961

Merged
merged 1 commit into from Jul 24, 2018

Conversation

Projects
None yet
3 participants
@pqarmitage
Collaborator

pqarmitage commented Jul 24, 2018

No description provided.

Fix buffer overflow in extract_status_code()
Issue #960 identified that the buffer allocated for copying the
HTTP status code could overflow if the http response was corrupted.

This commit changes the way the status code is read, avoids copying
data, and also ensures that the status code is three digits long,
is non-negative and occurs on the first line of the response.

Signed-off-by: Quentin Armitage <quentin@armitage.org.uk>

@pqarmitage pqarmitage merged commit 271d286 into acassen:master Jul 24, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jsegitz

This comment has been minimized.

jsegitz commented Nov 9, 2018

This was assigned CVE-2018-19115.

@acassen

This comment has been minimized.

Owner

acassen commented Nov 9, 2018

This issue has been fixed. Why NIST is refering to a NVD on this issue on 11/08 if this issue has been already fixed since 2.0.7. (the description is wrong : "through 2.0.8").
If you have the ability to close this CVE would you please help here ? Other CVE on follow links are open, and this issue is fixed too.
regs,

@jsegitz

This comment has been minimized.

jsegitz commented Nov 9, 2018

CVEs are used to track security issues. It doesn't matter if this has been fixed. I'll contact them and ask them to correct the version information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment