Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce clang formatting #207

Open
JRPan opened this issue May 10, 2023 · 1 comment
Open

Enforce clang formatting #207

JRPan opened this issue May 10, 2023 · 1 comment
Assignees

Comments

@JRPan
Copy link
Collaborator

JRPan commented May 10, 2023

No description provided.

@FJShen
Copy link
Contributor

FJShen commented May 11, 2023

Plan is to mimic the use of git hooks in GEM5. Python formatting should also be considered. The goal is to standardize the format of committed code.

pre-commit hook must be installed by the programmer. This can be done by adding the installation steps in setup_environment.sh

  1. Format all existing cpp and python code
  2. Lazily check and install pre-commit hooks in setup-env
  3. Enforce format check in Jenkins
  4. Describe formatting requirements in release documentation.

@FJShen FJShen linked a pull request Jun 26, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants